From: Stefan Roese <sr@denx.de>
To: Viresh Kumar <viresh.kumar@st.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"devicetree-discuss@ozlabs.org" <devicetree-discuss@ozlabs.org>,
spear-devel <spear-devel@list.st.com>,
Peppe CAVALLARO <peppe.cavallaro@st.com>
Subject: Re: [PATCH v2] stmmac: Add device-tree support
Date: Tue, 13 Mar 2012 12:40:45 +0100 [thread overview]
Message-ID: <201203131240.46050.sr@denx.de> (raw)
In-Reply-To: <4F5F2B56.2060504@st.com>
On Tuesday 13 March 2012 12:11:18 Viresh Kumar wrote:
> On 3/13/2012 3:59 PM, Stefan Roese wrote:
> > Consistency. pr_err is used in this driver. So I'm sticking to it with
> > this patch as well.
>
> Hmmm. I don't know, but can you add another patch before this one to move
> those prints.
Sure, I could. But I have to admit that this is currently not top of my
priority.
Peppe as driver maintainer might have some input here. Is this dev_err vs
pr_err a show-stopper for this patch?
Thanks,
Stefan
next prev parent reply other threads:[~2012-03-13 11:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-13 7:23 [PATCH v2] stmmac: Add device-tree support Stefan Roese
2012-03-13 8:53 ` Viresh Kumar
2012-03-13 10:29 ` Stefan Roese
2012-03-13 11:11 ` Viresh Kumar
2012-03-13 11:40 ` Stefan Roese [this message]
2012-03-13 11:43 ` Viresh Kumar
[not found] ` <1331623394-14600-1-git-send-email-sr-ynQEQJNshbs@public.gmane.org>
2012-03-13 14:18 ` Rob Herring
2012-03-13 14:28 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201203131240.46050.sr@denx.de \
--to=sr@denx.de \
--cc=devicetree-discuss@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=spear-devel@list.st.com \
--cc=viresh.kumar@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.