All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Henrik Rydberg <rydberg@bitmath.se>
Cc: linux-usb@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH] input: Fix autosuspend on bcm5974
Date: Tue, 13 Mar 2012 14:49:41 +0000	[thread overview]
Message-ID: <20120313144941.GA13637@srcf.ucam.org> (raw)
In-Reply-To: <20120313143958.GA2754@polaris.bitmath.org>

On Tue, Mar 13, 2012 at 03:39:58PM +0100, Henrik Rydberg wrote:

> With the previous version of this patch, the machine would not wake up
> on a normal tap. Is that what you refer to with the "small amount of
> additional latency"? By not enabled by default, you mean in the usb
> subsystem?

What do you mean by "normal tap"? By "not enabled by default" I mean the 
kernel doesn't enable autosuspend on input devices. Userspace would have 
to do that.

> Last time I checked, it seemed the first keystroke would sometimes
> disappear at boot. As far as I can see, this version modifies the
> needs_remote_wakeup variable to only be true while open, which might
> remove that particular problem.

I haven't seen any lost keystrokes.

-- 
Matthew Garrett | mjg59@srcf.ucam.org

  reply	other threads:[~2012-03-13 14:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-12 23:51 [PATCH] input: Fix autosuspend on bcm5974 Matthew Garrett
     [not found] ` <1331596278-2495-1-git-send-email-mjg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-03-12 22:27   ` Oliver Neukum
2012-03-13 14:39 ` Henrik Rydberg
2012-03-13 14:49   ` Matthew Garrett [this message]
2012-03-13 14:54     ` Oliver Neukum
2012-03-13 16:32     ` Henrik Rydberg
2012-03-13 16:40       ` Matthew Garrett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120313144941.GA13637@srcf.ucam.org \
    --to=mjg59@srcf.ucam.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=rydberg@bitmath.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.