All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Ian Campbell <ijc@hellion.org.uk>
Cc: Dan Williams <dan.j.williams@intel.com>,
	xen-devel@lists.xensource.com, Dave Jiang <dave.jiang@intel.com>,
	pkg-xen-devel@lists.alioth.debian.org,
	Thomas Goirand <zigo@debian.org>,
	Maciej Sosnowski <maciej.sosnowski@intel.com>,
	linux-kernel@vger.kernel.org,
	Jonathan Nieder <jrnieder@gmail.com>,
	William Dauchy <wdauchy@gmail.com>,
	Konrad Rzeszutek Wilk <konrad@darnok.org>
Subject: Re: [Xen-devel] [Pkg-xen-devel] ioatdma: Boot process hangs then reboots when using Xen + Linux 3.2
Date: Tue, 13 Mar 2012 12:49:02 -0400	[thread overview]
Message-ID: <20120313164902.GF19228@phenom.dumpdata.com> (raw)
In-Reply-To: <1331044752.22559.97.camel@cthulhu.hellion.org.uk>

On Tue, Mar 06, 2012 at 06:39:12AM -0800, Ian Campbell wrote:
> On Tue, 2012-03-06 at 06:14 -0800, Dan Williams wrote:
> > [    9.276817] ioatdma 0000:00:16.4: desc[0]:
> > (0x300cc7000->0x300cc7040) cookie: 0 flags: 0x2 ctl: 0x29 (op: 0
> > int_en: 1 compl: 1)
> > ...
> > [    9.276832] ioatdma 0000:00:16.4: ioat_get_current_completion:
> > phys_complete: 0xcc7000
> > 
> > Thanks, this clearly shows that our descriptors are above 4GB and that
> > the driver truncates the completion word.
> > 
> > Is this new behavior for xen?
> 
> Xen makes a distinction between physical addresses and DMA addresses and
> the latter can potentially be anywhere in the machine's real address
> space while the former is what GFP_KERNEL etc controls.
> 
> You are using pci_pool_alloc which is the correct API to use for these
> things since it's purpose is to handle cases where PHYS != DMA addr by
> exposing the DMA address to the caller. As part of that you should also
> be using dma_addr_t for DMA addresses since that is the type which is
> defined to handle the appropriate DMA address size on the platform.
> 
> I think this DMA!=PHYS can also be true of some non-x86 architectures

Especially SPARC.
> without Xen too but I guess ioat is quite x86 specific? In any case it
> is wrong, or at least non-portable, to use unsigned long for these
> addresses even though it happens on x86 that physaddr == dma addr
> (usually).

I think with the Intel VT-d that can be different. The bus addresses returned
do seem different.

  reply	other threads:[~2012-03-13 16:54 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-27 13:31 regression ioatdma 3.3 William Dauchy
2012-01-27 14:47 ` Konrad Rzeszutek Wilk
2012-01-27 15:02   ` William Dauchy
2012-02-19 22:31   ` Jonathan Nieder
2012-02-20 18:16     ` Jonathan Nieder
2012-02-25  7:46       ` Thomas Goirand
2012-02-25 21:13         ` William Dauchy
2012-03-02  5:57         ` ioatdma: Boot process hangs then reboots when using Xen + Linux 3.2 Jonathan Nieder
2012-03-02  6:42           ` Dan Williams
2012-03-02 16:21             ` [Pkg-xen-devel] " Bastian Blank
2012-03-02 16:21               ` Bastian Blank
2012-03-02 16:44               ` Dan Williams
2012-03-02 17:57                 ` Bastian Blank
2012-03-02 19:31                   ` Dan Williams
2012-03-02 20:08                     ` Bastian Blank
2012-03-02 20:16                       ` Dan Williams
2012-03-02 20:56                         ` Bastian Blank
2012-03-02 21:17                           ` Dan Williams
2012-03-05 15:26                     ` Thomas Goirand
2012-03-05 15:38                       ` Dan Williams
2012-03-06  9:20                         ` Thomas Goirand
2012-03-06 10:33                           ` Bastian Blank
2012-03-06 14:14                           ` Dan Williams
2012-03-06 14:39                             ` Ian Campbell
2012-03-06 14:39                               ` Ian Campbell
2012-03-13 16:49                               ` Konrad Rzeszutek Wilk [this message]
2012-03-11 22:06                             ` Jonathan Nieder
2012-03-23 23:55                               ` Dan Williams
2012-03-24  1:29                                 ` William Dauchy
2012-03-24  2:25                                 ` William Dauchy
2012-03-24  3:34                                   ` Williams, Dan J

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120313164902.GF19228@phenom.dumpdata.com \
    --to=konrad.wilk@oracle.com \
    --cc=dan.j.williams@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=ijc@hellion.org.uk \
    --cc=jrnieder@gmail.com \
    --cc=konrad@darnok.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maciej.sosnowski@intel.com \
    --cc=pkg-xen-devel@lists.alioth.debian.org \
    --cc=wdauchy@gmail.com \
    --cc=xen-devel@lists.xensource.com \
    --cc=zigo@debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.