All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: viro@zeniv.linux.org.uk
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: suppress page allocation failure warnings from sys_listxattr
Date: Tue, 13 Mar 2012 14:22:20 -0400	[thread overview]
Message-ID: <20120313182220.GA11500@redhat.com> (raw)

This size is user controllable, and so it's trivial for someone to trigger a
stream of order:4 page allocation errors.

Signed-off-by: Dave Jones <davej@redhat.com>

--- 
There's also a similar problem in setxattr, but I'm not sure how we want
to pass NOWARN down to memdup_user. Thoughts ?

diff --git a/fs/xattr.c b/fs/xattr.c
index 82f4337..544df90 100644
--- a/fs/xattr.c
+++ b/fs/xattr.c
@@ -496,7 +496,7 @@ listxattr(struct dentry *d, char __user *list, size_t size)
 	if (size) {
 		if (size > XATTR_LIST_MAX)
 			size = XATTR_LIST_MAX;
-		klist = kmalloc(size, GFP_KERNEL);
+		klist = kmalloc(size, __GFP_NOWARN | GFP_KERNEL);
 		if (!klist)
 			return -ENOMEM;
 	}

             reply	other threads:[~2012-03-13 18:22 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-13 18:22 Dave Jones [this message]
2012-03-13 21:33 ` suppress page allocation failure warnings from sys_listxattr Colin Walters
2012-03-27 22:51 ` Andrew Morton
2012-03-28  0:15   ` Dave Jones
2012-03-28  0:26     ` Andrew Morton
2012-03-28  7:13       ` David Rientjes
2012-03-28  4:39     ` Dave Chinner
2012-03-28 23:47       ` Andrew Morton
2012-03-29  0:54         ` Dave Jones
2012-03-29  1:10           ` Andrew Morton
2012-03-29  1:28             ` Joe Perches
2012-03-29  1:46               ` Andrew Morton
2012-03-29  1:50                 ` Dave Jones
2012-03-29  2:02                   ` Andrew Morton
2012-03-29  2:08                     ` Dave Jones
2012-03-29  2:28                       ` Andrew Morton
2012-03-29  3:00                         ` Dave Jones
2012-03-29 21:09                           ` Andrew Morton
2012-03-29 21:13                             ` Dave Jones
2012-03-29  5:35                 ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120313182220.GA11500@redhat.com \
    --to=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.