From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Kyungmin Park <kyungmin.park@samsung.com>,
MyungJoo Ham <myungjoo.ham@smasung.com>,
Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH] regulator: Check SET[1|2|3] GPIO settings earlier
Date: Tue, 13 Mar 2012 23:13:36 +0000 [thread overview]
Message-ID: <20120313231335.GQ3177@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1331607500.11322.3.camel@phoenix>
[-- Attachment #1: Type: text/plain, Size: 411 bytes --]
On Tue, Mar 13, 2012 at 10:58:20AM +0800, Axel Lin wrote:
> Unused GPIO is marked as -1, we need to check if one of the gpio is set to 0
> here because gpio_is_valid considers 0 as a valid gpio.
This will break existing boards, we need to manage the transfer more
gracefully and complain if we're using a GPIO 0. Though I'm not sure
it's worth bothering, I hope no modern gpiolib implementation will do
this.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-03-13 23:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-13 2:58 [PATCH] regulator: Check SET[1|2|3] GPIO settings earlier Axel Lin
2012-03-13 23:13 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120313231335.GQ3177@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=axel.lin@gmail.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=myungjoo.ham@smasung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.