All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/5] Microblaze: added architecture support for both big endian and low endian
Date: Wed, 14 Mar 2012 00:11:28 +0100	[thread overview]
Message-ID: <201203140011.29137.arnout@mind.be> (raw)
In-Reply-To: <4F5CD748.8050100@relinux.de>

On Sunday 11 March 2012 17:48:08 Stephan Hoffmann wrote:
> From: Alvaro G. M <alvaro.gamez@hazent.com>
> 
> Signed-off-by: Stephan Hoffmann <sho@relinux.de>
> Signed-off-by: Alvaro G. M <alvaro.gamez@hazent.com>
> ---
>  target/Config.in.arch |   15 +++++++++++++--
>  1 files changed, 13 insertions(+), 2 deletions(-)
> 
> diff --git a/target/Config.in.arch b/target/Config.in.arch
> index 25c6e50..83f128f 100644
> --- a/target/Config.in.arch
> +++ b/target/Config.in.arch
> @@ -21,6 +21,10 @@ config BR2_i386
>  config BR2_m68k
>  	bool "m68k"
>  	depends on BROKEN # ice in uclibc / inet_ntoa_r
> +config BR2_microblazeel
> +	bool "microblazeel"
> +config BR2_microblazebe
> +	bool "microblazebe"

 I would prefer the prompts to be a bit more descriptive, e.g.

config BR2_microblazeel
	bool "Microblaze (little-endian)"

 I realize that the other architectures all have cryptic names and no 
help text, but that doesn't mean we should do the same for new 
architectures.


 [snip]


 Regards,
 Arnout


-- 
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

      reply	other threads:[~2012-03-13 23:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-11 16:48 [Buildroot] [PATCH 1/5] Microblaze: added architecture support for both big endian and low endian Stephan Hoffmann
2012-03-13 23:11 ` Arnout Vandecappelle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201203140011.29137.arnout@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.