From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37856) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7jdw-0007hD-SH for qemu-devel@nongnu.org; Wed, 14 Mar 2012 04:33:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S7jdl-0002Lv-JS for qemu-devel@nongnu.org; Wed, 14 Mar 2012 04:33:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57223) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7jdl-0002Lh-Bp for qemu-devel@nongnu.org; Wed, 14 Mar 2012 04:33:01 -0400 Date: Wed, 14 Mar 2012 10:32:48 +0200 From: Alon Levy Message-ID: <20120314083248.GU27659@garlic.redhat.com> References: <1331483977-18910-1-git-send-email-alevy@redhat.com> <1331494004-26177-1-git-send-email-alevy@redhat.com> <1331494004-26177-5-git-send-email-alevy@redhat.com> <20120313103555.0ae4b834@doriath.home> <20120313144514.GK27659@garlic.redhat.com> <20120313125917.2b03a70c@doriath.home> <20120313173524.GO27659@garlic.redhat.com> <4F6055F9.8000409@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F6055F9.8000409@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 4/5] console: pass Monitor to vga_hw_screen_dump/hw_vga_dump List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, Luiz Capitulino On Wed, Mar 14, 2012 at 09:25:29AM +0100, Gerd Hoffmann wrote: > Hi, > > > ok, I'll take it. Note that I'm going to not send the qxl screendump > > behavior changing patch again, I think all alternatives to a real async > > screendump suck, including libvirt changes, and the current behavior of > > giving an old screendump is good enough hopefully for the real users, > > which are: > > Agree here. > > > boxes - refreshing to get updated thumbnails for it's users - will have > > 5 seconds old screenshot until async monitor commands land. > > autotest - I hope they don't compare image contents (that would be hard > > to do), otherwise it's just for logging sake, and so it will lag a > > little, too bad. > > autotest has (used to have?) a install mode where it looked at the > screen. I think it isn't used any more these days and unattended > install modes (kickstart etc.) of the guests are used instead. But even > when checking the screen content it should still work fine, just take a > little longer because the screen shots are a bit behind. > Right. Actually I thought about install mode and assumed it would break it but you're right, it shouldn't. > cheers, > Gerd >