From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/5] ARM: Add a printk loglevel modifier
Date: Wed, 14 Mar 2012 13:12:51 +0000 [thread overview]
Message-ID: <201203141312.51547.arnd@arndb.de> (raw)
In-Reply-To: <1331720516-11801-1-git-send-email-u.kleine-koenig@pengutronix.de>
On Wednesday 14 March 2012, Uwe Kleine-K?nig wrote:
> This is a needed followup for
>
> ARM: protect usage of cr_alignment by #ifdef CONFIG_CPU_CP15
>
> otherwise no newline is printed for !CONFIG_CPU_CP15
>
> Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> ---
> Should this be folded into the
>
> ARM: protect usage of cr_alignment by #ifdef CONFIG_CPU_CP15
>
> patch? Or should it come before it?
>
I think this patch needs a better explanation. It looks to me that
it's simply a bug fix, because every printk that is not a continuation
of a previous printk needs a KERN_* line. In that case, it should
just get applied as a bug fix independent of the other patches.
However, if you sometimes don't have a newline after the previous
printk, this patch is actually wrong and should not get applied at
all.
Arnd
next prev parent reply other threads:[~2012-03-14 13:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-14 10:19 [PATCH v3 0/5] ARM: Initial support for Cortex-M3 Uwe Kleine-König
2012-03-14 10:21 ` [PATCH v3 1/5] ARM: protect usage of cr_alignment by #ifdef CONFIG_CPU_CP15 Uwe Kleine-König
2012-03-14 15:24 ` Nicolas Pitre
2012-03-14 19:51 ` Uwe Kleine-König
2012-03-14 21:19 ` Nicolas Pitre
2012-03-14 21:53 ` Uwe Kleine-König
2012-03-14 10:21 ` [PATCH v3 2/5] ARM: Add a printk loglevel modifier Uwe Kleine-König
2012-03-14 13:12 ` Arnd Bergmann [this message]
2012-03-14 20:06 ` Uwe Kleine-König
2012-03-14 21:40 ` Arnd Bergmann
2012-03-14 15:26 ` Nicolas Pitre
2012-03-14 10:21 ` [PATCH v3 3/5] ARM: force branch instructions to use long distance encoding Uwe Kleine-König
2012-03-14 15:28 ` Nicolas Pitre
2012-03-14 10:21 ` [PATCH v3 4/5] Cortex-M3: Add base support for Cortex-M3 Uwe Kleine-König
2012-03-14 10:21 ` [PATCH v3 5/5] Cortex-M3: Add support for exception handling Uwe Kleine-König
2012-03-14 10:33 ` [PATCH v3 0/5] ARM: Initial support for Cortex-M3 Catalin Marinas
2012-03-14 13:15 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201203141312.51547.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.