From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Wed, 14 Mar 2012 13:27:00 +0000 Subject: [PATCH] ARM: SPEAr600: Add device-tree support to SPEAr600 boards In-Reply-To: <201203141136.48513.sr@denx.de> References: <1331650032-15274-1-git-send-email-sr@denx.de> <201203140948.44823.arnd@arndb.de> <201203141136.48513.sr@denx.de> Message-ID: <201203141327.01038.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wednesday 14 March 2012, Stefan Roese wrote: > On Wednesday 14 March 2012 10:48:44 Arnd Bergmann wrote: > > > > I would suggest you convert these to DT next so you can remove the > > > > amba_devs list. Which devices are these? If they are pl061 and > > > > pl010/pl011, the binding should be really easy to do. > > > > > > Yes. I really wanted to do that. But from a quick look at the pl011 > > > driver (drivers/tty/serial/amba-pl011.c), this driver doesn't support DT > > > probing. I might have missed something here though. And ideas? > > > > amba primecell devices don't actually need to register to a "compatible" > > property, they are probed using the primecell ID, and the device tree > > is just used to tell the system about memory and IRQ resources. > > Ahh, I see. Let me see, if I can get this working... I just saw that there is a patch series for pl061 that Rob Herring did at git://sources.calxeda.com/kernel/linux.git irqdomain-for-grant Please have a look at that branch first. > > Don't worry about the the gpio and uart devices if they are not in the > > first initial version. I do think that they should be done fairly soon > > though, before we get into most of the other devices. > > > > It's ok if you put a lot of the other devices in the dts file though, > > like the ethernet device, it gives a better overview of what is actually > > there, even if the driver does not actually use it yet. > > My initial idea was to push the devices once their DT support is accepted. > Otherwise the bindings are still not settled. Right, that makes sense. However, you can add a property containing status = "disabled; so that the device is visible in the source but no platform device gets generated. That would have no consequences at run time but can be helpful for review. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH] ARM: SPEAr600: Add device-tree support to SPEAr600 boards Date: Wed, 14 Mar 2012 13:27:00 +0000 Message-ID: <201203141327.01038.arnd@arndb.de> References: <1331650032-15274-1-git-send-email-sr@denx.de> <201203140948.44823.arnd@arndb.de> <201203141136.48513.sr@denx.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <201203141136.48513.sr-ynQEQJNshbs@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Stefan Roese Cc: devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org, spear-devel-nkJGhpqTU55BDgjK7y7TUQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Wednesday 14 March 2012, Stefan Roese wrote: > On Wednesday 14 March 2012 10:48:44 Arnd Bergmann wrote: > > > > I would suggest you convert these to DT next so you can remove the > > > > amba_devs list. Which devices are these? If they are pl061 and > > > > pl010/pl011, the binding should be really easy to do. > > > > > > Yes. I really wanted to do that. But from a quick look at the pl011 > > > driver (drivers/tty/serial/amba-pl011.c), this driver doesn't support DT > > > probing. I might have missed something here though. And ideas? > > > > amba primecell devices don't actually need to register to a "compatible" > > property, they are probed using the primecell ID, and the device tree > > is just used to tell the system about memory and IRQ resources. > > Ahh, I see. Let me see, if I can get this working... I just saw that there is a patch series for pl061 that Rob Herring did at git://sources.calxeda.com/kernel/linux.git irqdomain-for-grant Please have a look at that branch first. > > Don't worry about the the gpio and uart devices if they are not in the > > first initial version. I do think that they should be done fairly soon > > though, before we get into most of the other devices. > > > > It's ok if you put a lot of the other devices in the dts file though, > > like the ethernet device, it gives a better overview of what is actually > > there, even if the driver does not actually use it yet. > > My initial idea was to push the devices once their DT support is accepted. > Otherwise the bindings are still not settled. Right, that makes sense. However, you can add a property containing status = "disabled; so that the device is visible in the source but no platform device gets generated. That would have no consequences at run time but can be helpful for review. Arnd