From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:46400)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1S7oUD-00039e-Lv
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 09:43:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1S7oU4-0000iW-D0
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 09:43:29 -0400
Received: from mx1.redhat.com ([209.132.183.28]:24324)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1S7oU4-0000iL-5a
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 09:43:20 -0400
Date: Wed, 14 Mar 2012 15:43:08 +0200
From: Alon Levy <alevy@redhat.com>
Message-ID: <20120314134308.GJ27659@garlic.redhat.com>
References: <1331483977-18910-1-git-send-email-alevy@redhat.com>
	<1331494004-26177-1-git-send-email-alevy@redhat.com>
	<1331494004-26177-5-git-send-email-alevy@redhat.com>
	<20120313103555.0ae4b834@doriath.home>
	<20120313144514.GK27659@garlic.redhat.com>
	<4F605376.1050703@redhat.com> <20120314083713.GA26510@redhat.com>
	<20120314093258.4bdbc0a3@doriath.home>
	<20120314131410.GE27659@garlic.redhat.com>
	<20120314101812.206f9d14@doriath.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20120314101812.206f9d14@doriath.home>
Subject: Re: [Qemu-devel] [PATCH v2 4/5] console: pass Monitor to
 vga_hw_screen_dump/hw_vga_dump
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: aliguori@us.ibm.com, Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org

On Wed, Mar 14, 2012 at 10:18:12AM -0300, Luiz Capitulino wrote:
> On Wed, 14 Mar 2012 15:14:10 +0200
> Alon Levy <alevy@redhat.com> wrote:
> 
> > On Wed, Mar 14, 2012 at 09:32:58AM -0300, Luiz Capitulino wrote:
> > > On Wed, 14 Mar 2012 08:37:13 +0000
> > > "Daniel P. Berrange" <berrange@redhat.com> wrote:
> > > 
> > > > > First, with this applied you will not know the size in advance.  Also
> > > > > one of the approaches discussed is to allow passing in a file handle.
> > > > > That is a possible way to handle async screendumps too: just write to
> > > > > the passed file handle and close it when done.  Obvious drawback is that
> > > > > this will not cover the classic way of specifying the output filename as
> > > > > argument.
> > > 
> > > As Daniel explains below, this is not a drawback and there's no problem
> > > supporting multiple ways of returning the image.
> > > 
> > > The real drawback of making this w/o async support is that you can't detect
> > > errors.
> > > 
> > 
> > You also can't detect when the writing is done (unless you continuously
> > try to parse the file yourself..)
> 
> Oh, really? For some reason I had a pipe in my mind, but I honestly don't
> what's the semantics of fd passing in that regard.

Like Daniel pointed out, I am dead wrong here, sorry for the noise.