All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olaf Hering <olaf@aepfle.de>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Roger Pau Monne <roger.pau@entel.upc.edu>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] tools/qemu-xen: remove CFLAGS for qemu build
Date: Wed, 14 Mar 2012 19:07:56 +0100	[thread overview]
Message-ID: <20120314180756.GA7191@aepfle.de> (raw)
In-Reply-To: <20120314164615.GA22458@aepfle.de>

On Wed, Mar 14, Olaf Hering wrote:

> I noticed that @F is empty now, leading to ..d files in all directories.
> No idea how to fix that.
> tools/Rules.mk:CFLAGS += -MMD -MF .$(@F).d

> diff -r 773d03670872 config/Tools.mk.in
> --- a/config/Tools.mk.in
> +++ b/config/Tools.mk.in
> @@ -23,6 +23,10 @@ PREPEND_LIB         := @PREPEND_LIB@
>  APPEND_INCLUDES     := @APPEND_INCLUDES@
>  APPEND_LIB          := @APPEND_LIB@
>  
> +CFLAGS                        := @EXTRA_CFLAGS_XEN_TOOLS@
> +EXTRA_CFLAGS_QEMU_TRADITIONAL := @EXTRA_CFLAGS_QEMU_TRADITIONAL@
> +EXTRA_CFLAGS_QEMU_XEN         := @EXTRA_CFLAGS_QEMU_XEN@

The empty @F is fixed by using '+=' instead of ':=' above. With this
small change my attempt works for me, CFLAGS get passed properly to qemu
and tools itself.

Olaf

      reply	other threads:[~2012-03-14 18:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-23 16:45 [PATCH] tools/qemu-xen: remove CFLAGS for qemu build Olaf Hering
2012-03-01 17:42 ` Ian Jackson
2012-03-01 17:53   ` Olaf Hering
2012-03-01 18:20     ` Ian Jackson
2012-03-01 19:08       ` Olaf Hering
2012-03-02 11:51       ` Olaf Hering
2012-03-14 12:04         ` Ian Jackson
2012-03-14 16:46           ` Olaf Hering
2012-03-14 18:07             ` Olaf Hering [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120314180756.GA7191@aepfle.de \
    --to=olaf@aepfle.de \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=roger.pau@entel.upc.edu \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.