From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/5] ARM: protect usage of cr_alignment by #ifdef CONFIG_CPU_CP15
Date: Wed, 14 Mar 2012 22:53:44 +0100 [thread overview]
Message-ID: <20120314215344.GD2391@pengutronix.de> (raw)
In-Reply-To: <alpine.LFD.2.02.1203141710210.24151@xanadu.home>
Hello Nicolas,
On Wed, Mar 14, 2012 at 05:19:53PM -0400, Nicolas Pitre wrote:
> On Wed, 14 Mar 2012, Uwe Kleine-K?nig wrote:
> > On Wed, Mar 14, 2012 at 11:24:36AM -0400, Nicolas Pitre wrote:
> > > > flush_cache_all();
> > > > +#ifdef CONFIG_CPU_CP15
> > > > set_cr(cr_alignment);
> > > > +#endif
> > >
> > > However it might be best to provide a dummy set_cr() instead of
> > > #ifdef'ing it out everywhere.
> > What should the dummy set_cr do? Print a runtime warning if called with
> > != 0?
>
> Maybe not. In fact if that code path is used, then something might be
> wrong at a higher level.
And that's why I choosed not to implement a dummy set_cr ...
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2012-03-14 21:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-14 10:19 [PATCH v3 0/5] ARM: Initial support for Cortex-M3 Uwe Kleine-König
2012-03-14 10:21 ` [PATCH v3 1/5] ARM: protect usage of cr_alignment by #ifdef CONFIG_CPU_CP15 Uwe Kleine-König
2012-03-14 15:24 ` Nicolas Pitre
2012-03-14 19:51 ` Uwe Kleine-König
2012-03-14 21:19 ` Nicolas Pitre
2012-03-14 21:53 ` Uwe Kleine-König [this message]
2012-03-14 10:21 ` [PATCH v3 2/5] ARM: Add a printk loglevel modifier Uwe Kleine-König
2012-03-14 13:12 ` Arnd Bergmann
2012-03-14 20:06 ` Uwe Kleine-König
2012-03-14 21:40 ` Arnd Bergmann
2012-03-14 15:26 ` Nicolas Pitre
2012-03-14 10:21 ` [PATCH v3 3/5] ARM: force branch instructions to use long distance encoding Uwe Kleine-König
2012-03-14 15:28 ` Nicolas Pitre
2012-03-14 10:21 ` [PATCH v3 4/5] Cortex-M3: Add base support for Cortex-M3 Uwe Kleine-König
2012-03-14 10:21 ` [PATCH v3 5/5] Cortex-M3: Add support for exception handling Uwe Kleine-König
2012-03-14 10:33 ` [PATCH v3 0/5] ARM: Initial support for Cortex-M3 Catalin Marinas
2012-03-14 13:15 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120314215344.GD2391@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.