All of lore.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@amd64.org>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	Linux Edac Mailing List <linux-edac@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] edac: Add a sysfs node to test the EDAC error report facility
Date: Wed, 14 Mar 2012 23:33:09 +0100	[thread overview]
Message-ID: <20120314223309.GB27602@aftab> (raw)
In-Reply-To: <4F60F0D7.70505@redhat.com>

On Wed, Mar 14, 2012 at 04:26:15PM -0300, Mauro Carvalho Chehab wrote:
> > Then please move it to debugfs, where debugging stuff belongs.
> 
> There are other edac error injection tools at sysfs. That's why I opted to keep
> it there - plus, I was too lazy[1] to learn about the debugfs bits at the time I
> wrote it, and adding a single node to sysfs were very trivial ;)

I have to agree with Greg here, all debug-related stuff (error injection
being somewhat related) should go to debugfs.

Thanks.

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551

      reply	other threads:[~2012-03-14 22:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-07 12:08 [PATCH] edac: Add a sysfs node to test the EDAC error report facility Mauro Carvalho Chehab
2012-03-13 23:31 ` Greg KH
2012-03-14 19:26   ` Mauro Carvalho Chehab
2012-03-14 22:33     ` Borislav Petkov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120314223309.GB27602@aftab \
    --to=bp@amd64.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.