From: Andrew Morton <akpm@linux-foundation.org>
To: Konstantin Khlebnikov <khlebnikov@openvz.org>
Cc: Hugh Dickins <hughd@google.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCH v2 1/3] radix-tree: introduce bit-optimized iterator
Date: Wed, 14 Mar 2012 23:18:26 -0700 [thread overview]
Message-ID: <20120314231826.3938e451.akpm@linux-foundation.org> (raw)
In-Reply-To: <4F618347.8080400@openvz.org>
On Thu, 15 Mar 2012 09:51:03 +0400 Konstantin Khlebnikov <khlebnikov@openvz.org> wrote:
> > When a c programmer sees a variable called "i", he solidly expects it
> > to have type "int". Please choose a better name for this guy!
> > Perferably something which helps the reader understand what the
> > variable's role is.
>
> =) Ok, I can make it "int"
This should be an unsigned type - negative values are meaningless here.
And "i" is simply a poor identifier. A good identifier is one which
communicates the variable's role.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Konstantin Khlebnikov <khlebnikov@openvz.org>
Cc: Hugh Dickins <hughd@google.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCH v2 1/3] radix-tree: introduce bit-optimized iterator
Date: Wed, 14 Mar 2012 23:18:26 -0700 [thread overview]
Message-ID: <20120314231826.3938e451.akpm@linux-foundation.org> (raw)
In-Reply-To: <4F618347.8080400@openvz.org>
On Thu, 15 Mar 2012 09:51:03 +0400 Konstantin Khlebnikov <khlebnikov@openvz.org> wrote:
> > When a c programmer sees a variable called "i", he solidly expects it
> > to have type "int". Please choose a better name for this guy!
> > Perferably something which helps the reader understand what the
> > variable's role is.
>
> =) Ok, I can make it "int"
This should be an unsigned type - negative values are meaningless here.
And "i" is simply a poor identifier. A good identifier is one which
communicates the variable's role.
next prev parent reply other threads:[~2012-03-15 6:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-10 19:25 [PATCH v2 0/3] radix-tree: general iterator Konstantin Khlebnikov
2012-02-10 19:25 ` Konstantin Khlebnikov
2012-02-10 19:25 ` [PATCH v2 1/3] radix-tree: introduce bit-optimized iterator Konstantin Khlebnikov
2012-02-10 19:25 ` Konstantin Khlebnikov
2012-03-15 0:43 ` Andrew Morton
2012-03-15 0:43 ` Andrew Morton
2012-03-15 5:51 ` Konstantin Khlebnikov
2012-03-15 5:51 ` Konstantin Khlebnikov
2012-03-15 6:18 ` Andrew Morton [this message]
2012-03-15 6:18 ` Andrew Morton
2012-03-19 5:19 ` [PATCH v3] " Konstantin Khlebnikov
2012-03-19 5:19 ` Konstantin Khlebnikov
2012-03-19 23:42 ` Andrew Morton
2012-03-19 23:42 ` Andrew Morton
2012-03-20 5:28 ` Konstantin Khlebnikov
2012-03-20 5:28 ` Konstantin Khlebnikov
2012-02-10 19:25 ` [PATCH v2 2/3] radix-tree: rewrite gang lookup with using iterator Konstantin Khlebnikov
2012-02-10 19:25 ` Konstantin Khlebnikov
2012-02-10 19:25 ` [PATCH v2 3/3] radix-tree: use iterators in find_get_pages* functions Konstantin Khlebnikov
2012-02-10 19:25 ` Konstantin Khlebnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120314231826.3938e451.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=khlebnikov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.