From mboxrd@z Thu Jan 1 00:00:00 1970 From: sr@denx.de (Stefan Roese) Date: Thu, 15 Mar 2012 11:38:51 +0100 Subject: [PATCH] ARM: SPEAr600: Add device-tree support to SPEAr600 boards In-Reply-To: <4F61AFAB.6080301@st.com> References: <1331650032-15274-1-git-send-email-sr@denx.de> <201203150948.27918.sr@denx.de> <4F61AFAB.6080301@st.com> Message-ID: <201203151138.51508.sr@denx.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thursday 15 March 2012 10:00:27 Viresh Kumar wrote: > On 3/15/2012 2:18 PM, Stefan Roese wrote: > >>> > > +static const struct of_device_id vic_of_match[] __initconst = { > >>> > > + { .compatible = "arm,pl190-vic", .data = vic_of_init, }, > >>> > > + { /* Sentinel */ } > >>> > > +}; > >>> > > + > >>> > > +static void __init spear6xx_dt_init_irq(void) > >>> > > +{ > >>> > > + of_irq_init(vic_of_match); > >>> > > +} > >>> > > + > >> > > >> > What about adding this routine in vic.c file, which can then be used > >> > by all platforms, instead of replicating this code. > > > > We can't move vic_of_match to the vic.c, since there are differences > > between the boards using it. And only moving spear6xx_dt_init_irq() > > (renamed of course) doesn't seem worth it. > > I knew this. Actually my thought was, we have two compatible strings for > vic: pl190 and pl192. > > So, create two vic_of_match* arrays and two vic*_dt_init_irq() routines. > That will solve the issue i believe. I still don't think its worth it. But please feel free to send an add-on patch, to "clean this up". Thanks, Stefan From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Subject: Re: [PATCH] ARM: SPEAr600: Add device-tree support to SPEAr600 boards Date: Thu, 15 Mar 2012 11:38:51 +0100 Message-ID: <201203151138.51508.sr@denx.de> References: <1331650032-15274-1-git-send-email-sr@denx.de> <201203150948.27918.sr@denx.de> <4F61AFAB.6080301@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4F61AFAB.6080301-qxv4g6HH51o@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Viresh Kumar Cc: "devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org" , spear-devel , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: devicetree@vger.kernel.org On Thursday 15 March 2012 10:00:27 Viresh Kumar wrote: > On 3/15/2012 2:18 PM, Stefan Roese wrote: > >>> > > +static const struct of_device_id vic_of_match[] __initconst = { > >>> > > + { .compatible = "arm,pl190-vic", .data = vic_of_init, }, > >>> > > + { /* Sentinel */ } > >>> > > +}; > >>> > > + > >>> > > +static void __init spear6xx_dt_init_irq(void) > >>> > > +{ > >>> > > + of_irq_init(vic_of_match); > >>> > > +} > >>> > > + > >> > > >> > What about adding this routine in vic.c file, which can then be used > >> > by all platforms, instead of replicating this code. > > > > We can't move vic_of_match to the vic.c, since there are differences > > between the boards using it. And only moving spear6xx_dt_init_irq() > > (renamed of course) doesn't seem worth it. > > I knew this. Actually my thought was, we have two compatible strings for > vic: pl190 and pl192. > > So, create two vic_of_match* arrays and two vic*_dt_init_irq() routines. > That will solve the issue i believe. I still don't think its worth it. But please feel free to send an add-on patch, to "clean this up". Thanks, Stefan