From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: "Niklas Söderlund" <niklas.soderlund@ericsson.com>
Cc: <lucas.demarchi@profusion.mobi>, <borislav.petkov@amd.com>,
<linux-edac@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<thang.b.nguyen@dektech.com.au>
Subject: Re: [PATCH] edac: i5100 fix erroneous define for M1Err
Date: Thu, 15 Mar 2012 14:19:57 -0300 [thread overview]
Message-ID: <20120315141957.2245678a@redhat.com> (raw)
In-Reply-To: <1329475014-15589-1-git-send-email-niklas.soderlund@ericsson.com>
Em Fri, 17 Feb 2012 11:36:54 +0100
Niklas Söderlund <niklas.soderlund@ericsson.com> escreveu:
> According to [1] the define for M1Err in the FERR_NF_MEM register is
> wrong. It should be at position 1 not 0.
>
> [1] Intel 5100 Memory Controller Hub Chipset Doc.Nr: 318378
> http://www.intel.com/content/dam/doc/datasheet/5100-
> memory-controller-hub-chipset-datasheet.pdf
>
> Reported-by: Ba Thang Nguyen <thang.b.nguyen@dektech.com.au>
> Signed-off-by: Niklas Söderlund <niklas.soderlund@ericsson.com>
> ---
> drivers/edac/i5100_edac.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/edac/i5100_edac.c b/drivers/edac/i5100_edac.c
> index bcbdeec..ab2f906 100644
> --- a/drivers/edac/i5100_edac.c
> +++ b/drivers/edac/i5100_edac.c
> @@ -49,7 +49,7 @@
> #define I5100_FERR_NF_MEM_M6ERR_MASK (1 << 6)
> #define I5100_FERR_NF_MEM_M5ERR_MASK (1 << 5)
> #define I5100_FERR_NF_MEM_M4ERR_MASK (1 << 4)
> -#define I5100_FERR_NF_MEM_M1ERR_MASK 1
> +#define I5100_FERR_NF_MEM_M1ERR_MASK (1 << 1)
> #define I5100_FERR_NF_MEM_ANY_MASK \
> (I5100_FERR_NF_MEM_M16ERR_MASK | \
> I5100_FERR_NF_MEM_M15ERR_MASK | \
Looks fine. I'm applying on my edac -next tree, together with the other fix:
git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-edac.git linux-next
Cheers,
Mauro
prev parent reply other threads:[~2012-03-15 17:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-17 10:36 [PATCH] edac: i5100 fix erroneous define for M1Err Niklas Söderlund
2012-03-15 17:19 ` Mauro Carvalho Chehab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120315141957.2245678a@redhat.com \
--to=mchehab@redhat.com \
--cc=borislav.petkov@amd.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.demarchi@profusion.mobi \
--cc=niklas.soderlund@ericsson.com \
--cc=thang.b.nguyen@dektech.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.