From: Olaf Hering <olaf@aepfle.de>
To: Tim Deegan <tim@xen.org>
Cc: xen-devel@lists.xensource.com,
Andres Lagar-Cavilla <andres@lagarcavilla.org>,
adin@gridcentric.ca
Subject: Re: [PATCH 0 of 6] [RFC] Use wait queues for paging, v2
Date: Thu, 15 Mar 2012 16:37:12 +0100 [thread overview]
Message-ID: <20120315153712.GD7421@aepfle.de> (raw)
In-Reply-To: <20120315152745.GA11329@ocelot.phlegethon.org>
On Thu, Mar 15, Tim Deegan wrote:
> At 20:56 +0100 on 29 Feb (1330548983), Olaf Hering wrote:
> > On Wed, Feb 29, Olaf Hering wrote:
> >
> > > This is the domain_lock() in xenmem_add_to_physmap_once().
> > >
> > > Is get_gfn_untyped() correct, or would get_gfn_query() work as well in
> > > this context?
>
> get_gfn_untyped() is correct. I'm not sure that we really need to take
> the domain lock while we're doing it, though. It might be that the new
> gfn locks will be enough to serialize these updates.
>
> > Another case is emulate_privileged_op(), in "Write CR3" case
> > get_gfn_untyped() is called with domain_lock().
>
> I think that should be OK as it only happens for PV guests.
I think its just me not knowing these things, but would it make sense to
add comments to XX_lock users describing what they protect (or used to
protect since comments can stale over time)?
Olaf
next prev parent reply other threads:[~2012-03-15 15:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-23 16:34 [PATCH 0 of 6] [RFC] Use wait queues for paging, v2 Tim Deegan
2012-02-23 16:34 ` [PATCH 1 of 6] mm: guest_remove_page() should not populate or unshare Tim Deegan
2012-02-23 16:34 ` [PATCH 2 of 6] x86/mm: remove 'p2m_guest' lookup type Tim Deegan
2012-02-23 16:34 ` [PATCH 3 of 6] x86/mm: make 'query type' argument to get_gfn into a set of flags Tim Deegan
2012-02-23 16:45 ` Andres Lagar-Cavilla
2012-02-23 16:34 ` [PATCH 4 of 6] x86/mm: tidy up get_two_gfns() a little Tim Deegan
2012-02-23 16:34 ` [PATCH 5 of 6] [RFC] x86/mm: use wait queues for mem_paging Tim Deegan
2012-02-24 13:45 ` Olaf Hering
2012-02-27 19:26 ` Tim Deegan
2012-02-27 20:18 ` Olaf Hering
2012-02-23 16:34 ` [PATCH 6 of 6] x86/mm: Don't claim a slot on the paging ring if we might not need it Tim Deegan
2012-02-23 16:48 ` Andres Lagar-Cavilla
2012-02-23 16:43 ` [PATCH 0 of 6] [RFC] Use wait queues for paging, v2 Tim Deegan
2012-02-23 16:49 ` Andres Lagar-Cavilla
2012-02-26 22:14 ` Olaf Hering
2012-02-27 16:51 ` Olaf Hering
[not found] ` <EC947F02-8448-45B0-A240-8BBD41C3F9B7@gridcentric.ca>
2012-02-28 21:11 ` Andres Lagar-Cavilla
2012-02-29 16:18 ` Olaf Hering
2012-02-29 19:56 ` Olaf Hering
2012-03-15 15:27 ` Tim Deegan
2012-03-15 15:37 ` Olaf Hering [this message]
2012-03-15 15:40 ` Tim Deegan
2012-03-15 15:56 ` Andres Lagar-Cavilla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120315153712.GD7421@aepfle.de \
--to=olaf@aepfle.de \
--cc=adin@gridcentric.ca \
--cc=andres@lagarcavilla.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.