All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Lennart Poettering <mzxreary-uLTowLwuiw4b1SvskN2V4Q@public.gmane.org>
Cc: Li Zefan <lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>,
	containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Frederic Weisbecker
	<fweisbec-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] cgroup: deprecate remount option changes and "name=" mount option
Date: Thu, 15 Mar 2012 09:54:02 -0700	[thread overview]
Message-ID: <20120315165402.GC32137@google.com> (raw)
In-Reply-To: <20120314232925.GA16973-kS5D54t9nk0aINubkmmoJbNAH6kLmebB@public.gmane.org>

Hello,

On Thu, Mar 15, 2012 at 12:29:25AM +0100, Lennart Poettering wrote:
> Hmm, this is not clear to me. Are you intending to remove the name=
> mount option entirely, or just intend to remove that you can change it
> in remounts?
> 
> systemd uses name=systemd to get its own private cgroup tree, that has
> no controller bound, hence we kinda need this option. Or are you
> suggesting there was an other way to get a private cgroup tree that
> systemd can use for grouping and labelling things?

Eh, you're right.  I want to remove support for duplicate mounting by
name or subsys as it just isn't necessary, so what I want is,

* "mount -t cgroupfs -o SUBSYS" will fail if SUBSYS is already mounted
  somewhere else.

* "mount -t cgroupfs -o none" will always create a new cgroup
  hierarchy w/o any controller attached.

I didn't realize that the mount code didn't allow none w/o name and
now I don't see a non-intrusive way to remove the name option. :( Eh
well, I'll drop that part.

Thanks.

-- 
tejun

WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: Lennart Poettering <mzxreary@0pointer.de>
Cc: Li Zefan <lizf@cn.fujitsu.com>,
	containers@lists.linux-foundation.org, cgroups@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH] cgroup: deprecate remount option changes and "name=" mount option
Date: Thu, 15 Mar 2012 09:54:02 -0700	[thread overview]
Message-ID: <20120315165402.GC32137@google.com> (raw)
In-Reply-To: <20120314232925.GA16973@tango.0pointer.de>

Hello,

On Thu, Mar 15, 2012 at 12:29:25AM +0100, Lennart Poettering wrote:
> Hmm, this is not clear to me. Are you intending to remove the name=
> mount option entirely, or just intend to remove that you can change it
> in remounts?
> 
> systemd uses name=systemd to get its own private cgroup tree, that has
> no controller bound, hence we kinda need this option. Or are you
> suggesting there was an other way to get a private cgroup tree that
> systemd can use for grouping and labelling things?

Eh, you're right.  I want to remove support for duplicate mounting by
name or subsys as it just isn't necessary, so what I want is,

* "mount -t cgroupfs -o SUBSYS" will fail if SUBSYS is already mounted
  somewhere else.

* "mount -t cgroupfs -o none" will always create a new cgroup
  hierarchy w/o any controller attached.

I didn't realize that the mount code didn't allow none w/o name and
now I don't see a non-intrusive way to remove the name option. :( Eh
well, I'll drop that part.

Thanks.

-- 
tejun

  parent reply	other threads:[~2012-03-15 16:54 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-14 21:52 [PATCH] cgroup: deprecate remount option changes and "name=" mount option Tejun Heo
2012-03-14 21:52 ` Tejun Heo
     [not found] ` <20120314215228.GI7349-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-03-14 23:29   ` Lennart Poettering
2012-03-14 23:29   ` Lennart Poettering
2012-03-14 23:29     ` Lennart Poettering
     [not found]     ` <20120314232925.GA16973-kS5D54t9nk0aINubkmmoJbNAH6kLmebB@public.gmane.org>
2012-03-15 16:54       ` Tejun Heo [this message]
2012-03-15 16:54         ` Tejun Heo
     [not found]         ` <20120315165402.GC32137-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-03-15 19:33           ` Lennart Poettering
2012-03-15 19:33           ` Lennart Poettering
2012-03-15 19:33             ` Lennart Poettering
2012-03-15 16:54       ` Tejun Heo
2012-03-15  2:39   ` Serge Hallyn
2012-03-15 16:56   ` [PATCH] cgroup: deprecate remount option changes " Tejun Heo
2012-03-15 16:56     ` Tejun Heo
     [not found]     ` <20120315165655.GD32137-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-03-15 19:36       ` Lennart Poettering
2012-03-15 19:36         ` Lennart Poettering
     [not found]         ` <20120315193635.GD32661-kS5D54t9nk0aINubkmmoJbNAH6kLmebB@public.gmane.org>
2012-03-15 19:45           ` Tejun Heo
2012-03-15 19:45             ` Tejun Heo
2012-03-31 16:41       ` Tejun Heo
2012-03-31 16:41         ` Tejun Heo
2012-03-31 16:41       ` Tejun Heo
  -- strict thread matches above, loose matches on Subject: below --
2012-03-14 21:52 [PATCH] cgroup: deprecate remount option changes and "name=" " Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120315165402.GC32137@google.com \
    --to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=fweisbec-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org \
    --cc=mzxreary-uLTowLwuiw4b1SvskN2V4Q@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.