All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Lennart Poettering <mzxreary-uLTowLwuiw4b1SvskN2V4Q@public.gmane.org>
Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Frederic Weisbecker
	<fweisbec-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] cgroup: deprecate remount option changes mount option
Date: Thu, 15 Mar 2012 12:45:45 -0700	[thread overview]
Message-ID: <20120315194545.GG32137@google.com> (raw)
In-Reply-To: <20120315193635.GD32661-kS5D54t9nk0aINubkmmoJbNAH6kLmebB@public.gmane.org>

Hello,

On Thu, Mar 15, 2012 at 08:36:35PM +0100, Lennart Poettering wrote:
> > * release_agent update by remount: release_agent itself will be
> >   replaced with conventional fsnotify notification.
> 
> Just wondering, what kind of event do you plan to emit if a cgroup runs
> empty? To userspace, with fanotify, will this be FAN_MODIFY? I'd very
> much prefer if we only get events really when a group runs empty, and
> not each time a PID is added/removed from a cgroup, which FAN_NOTIFY
> might suggest?

MODIFY probably is the only thing which makes sense and I don't think
we would be emitting events for every task addition/removals.  That
better fits MODIFY events on the tasks file anyway.

Thanks.

-- 
tejun

WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: Lennart Poettering <mzxreary@0pointer.de>
Cc: Li Zefan <lizf@cn.fujitsu.com>,
	containers@lists.linux-foundation.org, cgroups@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH] cgroup: deprecate remount option changes mount option
Date: Thu, 15 Mar 2012 12:45:45 -0700	[thread overview]
Message-ID: <20120315194545.GG32137@google.com> (raw)
In-Reply-To: <20120315193635.GD32661@tango.0pointer.de>

Hello,

On Thu, Mar 15, 2012 at 08:36:35PM +0100, Lennart Poettering wrote:
> > * release_agent update by remount: release_agent itself will be
> >   replaced with conventional fsnotify notification.
> 
> Just wondering, what kind of event do you plan to emit if a cgroup runs
> empty? To userspace, with fanotify, will this be FAN_MODIFY? I'd very
> much prefer if we only get events really when a group runs empty, and
> not each time a PID is added/removed from a cgroup, which FAN_NOTIFY
> might suggest?

MODIFY probably is the only thing which makes sense and I don't think
we would be emitting events for every task addition/removals.  That
better fits MODIFY events on the tasks file anyway.

Thanks.

-- 
tejun

  parent reply	other threads:[~2012-03-15 19:45 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-14 21:52 [PATCH] cgroup: deprecate remount option changes and "name=" mount option Tejun Heo
2012-03-14 21:52 ` Tejun Heo
     [not found] ` <20120314215228.GI7349-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-03-14 23:29   ` Lennart Poettering
2012-03-14 23:29   ` Lennart Poettering
2012-03-14 23:29     ` Lennart Poettering
     [not found]     ` <20120314232925.GA16973-kS5D54t9nk0aINubkmmoJbNAH6kLmebB@public.gmane.org>
2012-03-15 16:54       ` Tejun Heo
2012-03-15 16:54         ` Tejun Heo
     [not found]         ` <20120315165402.GC32137-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-03-15 19:33           ` Lennart Poettering
2012-03-15 19:33           ` Lennart Poettering
2012-03-15 19:33             ` Lennart Poettering
2012-03-15 16:54       ` Tejun Heo
2012-03-15  2:39   ` Serge Hallyn
2012-03-15 16:56   ` [PATCH] cgroup: deprecate remount option changes " Tejun Heo
2012-03-15 16:56     ` Tejun Heo
     [not found]     ` <20120315165655.GD32137-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-03-15 19:36       ` Lennart Poettering
2012-03-15 19:36         ` Lennart Poettering
     [not found]         ` <20120315193635.GD32661-kS5D54t9nk0aINubkmmoJbNAH6kLmebB@public.gmane.org>
2012-03-15 19:45           ` Tejun Heo [this message]
2012-03-15 19:45             ` Tejun Heo
2012-03-31 16:41       ` Tejun Heo
2012-03-31 16:41       ` Tejun Heo
2012-03-31 16:41         ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120315194545.GG32137@google.com \
    --to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=fweisbec-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mzxreary-uLTowLwuiw4b1SvskN2V4Q@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.