From: Andrew Miller <amiller@amilx.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] Staging: rtl8187se: r8180_dm.c: Fix comments
Date: Thu, 15 Mar 2012 16:49:23 -0400 [thread overview]
Message-ID: <20120315204923.GA14240@iron> (raw)
In-Reply-To: <20120315193405.GE3163@mwanda>
On Thu, Mar 15, 2012 at 10:34:05PM +0300, Dan Carpenter wrote:
> On Thu, Mar 15, 2012 at 03:05:21PM -0400, Andrew Miller wrote:
> > -//+by amy 080312
> > +/*{by amy 080312 */
> ^^^^^^^^^^^^^
> Just remove these comments. We use version control to see who is
> doing what.
>
> >
> > - //printk("----> DoTxHighPower()\n");
> > + /* printk("----> DoTxHighPower()\n"); */
> >
>
> Also this dead debugging code can be deleted. There was a bunch of
> it.
>
> regards,
> dan carpenter
Thanks for the advice, If the patch goes through. I'll make another one
with this changes. If not then I will include them when I revise it.
next prev parent reply other threads:[~2012-03-15 20:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-15 19:05 [PATCH 0/5] Staging: rtl8187se: r8180_dm.c: Fix Coding Style issues Andrew Miller
2012-03-15 19:05 ` [PATCH 1/5] Staging: rtl8187se: r8180_dm.c: Removed spaces before tab stop Andrew Miller
2012-03-15 19:05 ` [PATCH 2/5] Staging: rtl8187se: r8180_dm.c: Fix brackets Andrew Miller
2012-03-15 19:05 ` [PATCH 3/5] Staging: rtl8187se: r8180_dm.c Fixed indentation issues Andrew Miller
2012-03-15 19:05 ` [PATCH 4/5] Staging: rtl8187se: r8180_dm.c: Fix spacing issues Andrew Miller
2012-03-15 19:05 ` [PATCH 5/5] Staging: rtl8187se: r8180_dm.c: Fix comments Andrew Miller
2012-03-15 19:34 ` Dan Carpenter
2012-03-15 20:49 ` Andrew Miller [this message]
2012-03-15 21:08 ` Greg KH
2012-03-15 21:15 ` Andrew Miller
2012-03-15 21:24 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120315204923.GA14240@iron \
--to=amiller@amilx.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.