From: Greg KH <gregkh@linuxfoundation.org>
To: Mircea Gherzan <mgherzan@gmail.com>
Cc: alexandrasava18@gmail.com, pavan_savoy@ti.com,
daniel.baluta@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ti-st: Enhange logging for Shared Transport - TI driver
Date: Thu, 15 Mar 2012 17:35:23 -0700 [thread overview]
Message-ID: <20120316003523.GA25149@kroah.com> (raw)
In-Reply-To: <4F6289B3.2060204@gmail.com>
On Fri, Mar 16, 2012 at 01:30:43AM +0100, Mircea Gherzan wrote:
>
> This is what I get now (with no debug) when loading the btwilink module
> that uses ti-st:
>
> [ 129.567382] (stk) :change remote baud rate command in firmware
> [ 129.573577] (stk) :skipping the wait event of change remote baud
>
> This is:
> 1. too "verbose" => these 2 prints should belong to debug
> 2. poorly formated
> 3. not telling me which driver generated this output
> 4. not giving me the version of the firmware that was loaded.
>
> To address 2 and 3, please remove the the "(stc)" / "(stk)" prefixes and
> use instead the quite widespread prefix KBUILD_MODNAME ": "
No, just use the proper dev_*() functions instead, it will tell you
exactly what driver and device emitted the message, that is what it is
there for.
thanks,
greg k-h
next prev parent reply other threads:[~2012-03-16 0:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-15 18:26 [PATCH] ti-st: Enhange logging for Shared Transport - TI driver alexandrasava18
2012-03-15 20:17 ` Daniel Baluta
2012-03-15 20:29 ` Savoy, Pavan
2012-03-15 21:10 ` Alexandra Sava
2012-03-15 21:17 ` Alexandra Sava
2012-03-15 21:23 ` gregkh
2012-03-16 0:30 ` Mircea Gherzan
2012-03-16 0:35 ` Greg KH [this message]
2012-03-16 0:41 ` Joe Perches
2012-03-16 0:51 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120316003523.GA25149@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alexandrasava18@gmail.com \
--cc=daniel.baluta@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgherzan@gmail.com \
--cc=pavan_savoy@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.