From: Dan Carpenter <dan.carpenter@oracle.com>
To: Andrew Miller <amiller@amilx.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/6] Staging: rtl8187se: r8180_dm.c: Removed old comments
Date: Fri, 16 Mar 2012 08:26:12 +0300 [thread overview]
Message-ID: <20120316052612.GF3163@mwanda> (raw)
In-Reply-To: <1331850519-20726-1-git-send-email-amiller@amilx.com>
[-- Attachment #1: Type: text/plain, Size: 1308 bytes --]
On Thu, Mar 15, 2012 at 06:28:39PM -0400, Andrew Miller wrote:
> Removed some old comments
>
> Signed-off-by: Andrew Miller <amiller@amilx.com>
> ---
> drivers/staging/rtl8187se/r8180_dm.c | 307 +++-------------------------------
> 1 files changed, 21 insertions(+), 286 deletions(-)
>
> diff --git a/drivers/staging/rtl8187se/r8180_dm.c b/drivers/staging/rtl8187se/r8180_dm.c
> index 54b676f..4d7a595 100644
> --- a/drivers/staging/rtl8187se/r8180_dm.c
> +++ b/drivers/staging/rtl8187se/r8180_dm.c
> @@ -1,15 +1,8 @@
> -/*#include "r8180.h" */
> #include "r8180_dm.h"
> #include "r8180_hw.h"
> #include "r8180_93cx6.h"
> -/*{by amy 080312 */
>
> -/*
> - * Description:
> - * Return TRUE if we shall perform High Power Mecahnism, FALSE otherwise.
> - *
> - *+by amy 080312
> - */
> + /* Return TRUE if we shall perform High Power Mecahnism, FALSE otherwise. */
> #define RATE_ADAPTIVE_TIMER_PERIOD 300
>
> bool CheckHighPower(struct net_device *dev)
I meant just remove the "*+by amy 080312" line, but I don't really
mind how you redid the formatting either. Btw, the comment should
probably be a line below to go with the CheckHighPower() function
or people will think it belongs to the RATE_ADAPTIVE_TIMER_PERIOD
macro.
regards,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-03-16 5:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-15 22:28 [PATCH 6/6] Staging: rtl8187se: r8180_dm.c: Removed old comments Andrew Miller
2012-03-15 23:41 ` Greg KH
2012-03-15 23:48 ` Andrew Miller
2012-03-16 5:26 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120316052612.GF3163@mwanda \
--to=dan.carpenter@oracle.com \
--cc=amiller@amilx.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.