From: Dan Carpenter <dan.carpenter@oracle.com>
To: "K. Y. Srinivasan" <kys@microsoft.com>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
devel@linuxdriverproject.org, virtualization@lists.osdl.org,
ohering@suse.com, Alan Stern <stern@rowland.harvard.edu>
Subject: Re: [PATCH 1/3] Drivers: hv: Support the newly introduced KVP messages in the driver
Date: Fri, 16 Mar 2012 08:45:56 +0300 [thread overview]
Message-ID: <20120316054556.GH3163@mwanda> (raw)
In-Reply-To: <1331858925-827-1-git-send-email-kys@microsoft.com>
[-- Attachment #1: Type: text/plain, Size: 708 bytes --]
On Thu, Mar 15, 2012 at 05:48:43PM -0700, K. Y. Srinivasan wrote:
> /*
> * The windows host expects the key/value pair to be encoded
> * in utf16.
> */
> keylen = utf8s_to_utf16s(key_name, strlen(key_name), UTF16_HOST_ENDIAN,
> - (wchar_t *) kvp_data->data.key,
> + (wchar_t *) kvp_data->key,
> HV_KVP_EXCHANGE_MAX_KEY_SIZE / 2);
> - kvp_data->data.key_size = 2*(keylen + 1); /* utf16 encoding */
> + kvp_data->key_size = 2*(keylen + 1); /* utf16 encoding */
> +
I feel like a jerk for asking this, but is the output length correct
here? It seems like we could go over again. Also utf8s_to_utf16s()
can return negative error codes, why do we ignore those?
regards,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-03-16 5:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-16 0:48 [PATCH 0000/0003] drivers: hv K. Y. Srinivasan
2012-03-16 0:48 ` K. Y. Srinivasan
2012-03-16 0:48 ` [PATCH 1/3] Drivers: hv: Support the newly introduced KVP messages in the driver K. Y. Srinivasan
2012-03-16 0:48 ` [PATCH 2/3] Tools: hv: Fully support the new KVP verbs in the user level daemon K. Y. Srinivasan
2012-03-16 0:48 ` K. Y. Srinivasan
2012-03-16 0:48 ` [PATCH 3/3] Tools: hv: Support enumeration from all the pools K. Y. Srinivasan
2012-03-16 5:45 ` Dan Carpenter [this message]
2012-03-16 6:33 ` [PATCH 1/3] Drivers: hv: Support the newly introduced KVP messages in the driver KY Srinivasan
2012-03-16 6:33 ` KY Srinivasan
2012-03-16 7:18 ` Dan Carpenter
2012-03-16 7:18 ` Dan Carpenter
2012-03-16 7:37 ` Dan Carpenter
2012-03-16 7:37 ` Dan Carpenter
2012-03-16 13:14 ` KY Srinivasan
2012-03-16 14:26 ` Dan Carpenter
2012-03-16 14:26 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120316054556.GH3163@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ohering@suse.com \
--cc=stern@rowland.harvard.edu \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.