From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Fri, 16 Mar 2012 12:14:35 +0000 Subject: [PATCH v4] ARM: SPEAr600: Add device-tree support to SPEAr600 boards In-Reply-To: <1331890216-8361-1-git-send-email-sr@denx.de> References: <1331890216-8361-1-git-send-email-sr@denx.de> Message-ID: <201203161214.35929.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Friday 16 March 2012, Stefan Roese wrote: > v4: > - Added memory node to all dts/dtsi files > - Reorganizes bus topology in the dtsi file, to match the > real SoC layout Looks good. > + > + ahb { > + #address-cells = <1>; > + #size-cells = <1>; > + compatible = "simple-bus"; > + ranges; > + > + vic0: interrupt-controller at f1100000 { > + compatible = "arm,pl190-vic"; > + interrupt-controller; > + reg = <0xf1100000 0x1000>; > + #interrupt-cells = <1>; > + }; > + > ... > + apb { > + #address-cells = <1>; > + #size-cells = <1>; > + compatible = "simple-bus"; > + ranges; > + > + serial at d0000000 { > + compatible = "arm,pl011", "arm,primecell"; > + reg = <0xd0000000 0x1000>; > + interrupt-parent = <&vic0>; > + interrupts = <24>; > + }; > ... > + }; > + }; > +}; I would prefer to see non-empty ranges properties here. I expected the buses to be contiguous address ranges per bus, but apparently that is not the case -- you have 0xd... and 0xf... on both of them. The simplest ranges property would be to have in the ahb node: ranges = <0xd0000000 0xd0000000 0x30000000>; Which just means that the bus is limited to those addresses (if that is indeed the case -- I don't know much about ahb and apb). Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v4] ARM: SPEAr600: Add device-tree support to SPEAr600 boards Date: Fri, 16 Mar 2012 12:14:35 +0000 Message-ID: <201203161214.35929.arnd@arndb.de> References: <1331890216-8361-1-git-send-email-sr@denx.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1331890216-8361-1-git-send-email-sr-ynQEQJNshbs@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Stefan Roese Cc: Viresh Kumar , devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org, spear-devel-nkJGhpqTU55BDgjK7y7TUQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Friday 16 March 2012, Stefan Roese wrote: > v4: > - Added memory node to all dts/dtsi files > - Reorganizes bus topology in the dtsi file, to match the > real SoC layout Looks good. > + > + ahb { > + #address-cells = <1>; > + #size-cells = <1>; > + compatible = "simple-bus"; > + ranges; > + > + vic0: interrupt-controller@f1100000 { > + compatible = "arm,pl190-vic"; > + interrupt-controller; > + reg = <0xf1100000 0x1000>; > + #interrupt-cells = <1>; > + }; > + > ... > + apb { > + #address-cells = <1>; > + #size-cells = <1>; > + compatible = "simple-bus"; > + ranges; > + > + serial@d0000000 { > + compatible = "arm,pl011", "arm,primecell"; > + reg = <0xd0000000 0x1000>; > + interrupt-parent = <&vic0>; > + interrupts = <24>; > + }; > ... > + }; > + }; > +}; I would prefer to see non-empty ranges properties here. I expected the buses to be contiguous address ranges per bus, but apparently that is not the case -- you have 0xd... and 0xf... on both of them. The simplest ranges property would be to have in the ahb node: ranges = <0xd0000000 0xd0000000 0x30000000>; Which just means that the bus is limited to those addresses (if that is indeed the case -- I don't know much about ahb and apb). Arnd