From: Andrew Morton <akpm@linux-foundation.org>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Julia Lawall <Julia.Lawall@lip6.fr>
Subject: Re: [PATCHv2 3/3] simple_open: Automatically convert to simple_open()
Date: Fri, 16 Mar 2012 16:49:11 -0700 [thread overview]
Message-ID: <20120316164911.dbc089de.akpm@linux-foundation.org> (raw)
In-Reply-To: <1331631988-20527-4-git-send-email-sboyd@codeaurora.org>
On Tue, 13 Mar 2012 02:46:28 -0700
Stephen Boyd <sboyd@codeaurora.org> wrote:
> Many users of debugfs copy the implementation of default_open()
> when they want to support a custom read/write function op. This
> leads to a proliferation of the default_open() implementation
> across the entire tree. Now that the common implementation has
> been consolidated into libfs we can replace all the users of this
> function with simple_open().
>
>
> ...
>
> --- a/drivers/net/wireless/wl12xx/debugfs.c
> +++ b/drivers/net/wireless/wl12xx/debugfs.c
>
This broke.
I'm hitting quite a lot of build errors from this patch. I'm not
confident that I will be able to compile-test every file that it
touches so I shall drop the patch.
Please fix it all up, compile-test *every* file, then resend.
If possible, against linux-next, please. Quite a few things in this
area have been changed.
next prev parent reply other threads:[~2012-03-16 23:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-13 9:46 [PATCHv2 0/3] Introduce simple_open() Stephen Boyd
2012-03-13 9:46 ` [PATCHv2 1/3] libfs: Add simple_open() Stephen Boyd
2012-03-13 9:46 ` [PATCHv2 2/3] coccinelle: semantic patch for simple_open() Stephen Boyd
2012-03-13 9:46 ` [PATCHv2 3/3] simple_open: Automatically convert to simple_open() Stephen Boyd
2012-03-13 10:23 ` Ingo Molnar
2012-03-13 16:14 ` Greg Kroah-Hartman
2012-03-16 23:49 ` Andrew Morton [this message]
2012-03-17 9:21 ` [PATCHv2] " Stephen Boyd
2012-03-19 11:11 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120316164911.dbc089de.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Julia.Lawall@lip6.fr \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@codeaurora.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.