From: Grant Likely <grant.likely@secretlab.ca>
To: Tabi Timur-B04825 <B04825@freescale.com>
Cc: "devicetree-discuss@lists.ozlabs.org Discuss"
<devicetree-discuss@lists.ozlabs.org>,
"linuxppc-dev@lists.ozlabs.org list"
<linuxppc-dev@lists.ozlabs.org>
Subject: Re: issues calling of_platform_bus_probe() twice
Date: Sun, 18 Mar 2012 09:08:04 +0000 [thread overview]
Message-ID: <20120318090804.C70493E060A@localhost> (raw)
In-Reply-To: <4F649304.9010001@freescale.com>
On Sat, 17 Mar 2012 13:35:02 +0000, Tabi Timur-B04825 <B04825@freescale.com> wrote:
> Grant Likely wrote:
> >>> > > Are you aware of any reason that we can't call of_platform_bus_probe()
> >>> > > or multiple times. Timur's run into an issue in which all devices
> >>> > > don't get registered properly if we call of_platform_bus_probe() times
> >>> > > with different of_device_id struct's.
> >> >
> >> > Nothing comes to mind... Grant ?
> > Neither for me. Should work.
>
> I posted a work-around patch here:
>
> http://patchwork.ozlabs.org/patch/128533/
>
> Without this patch, drivers cannot probe on DMA *channels*, or any other
> grandchildren of the root node.
That's because you're using it wrong. of_platform_bus_probe() creates
platform devices at the starting level and every level below it as
described by the bus ids. It is illegal to call of_platform_bus_probe()
twice at the same level in the DT.
g.
next prev parent reply other threads:[~2012-03-18 9:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-16 21:21 issues calling of_platform_bus_probe() twice Kumar Gala
2012-03-16 21:21 ` Kumar Gala
2012-03-16 21:23 ` Benjamin Herrenschmidt
2012-03-16 21:23 ` Benjamin Herrenschmidt
2012-03-17 7:27 ` Grant Likely
2012-03-17 7:27 ` Grant Likely
2012-03-17 13:35 ` Tabi Timur-B04825
2012-03-17 13:35 ` Tabi Timur-B04825
2012-03-17 23:29 ` Benjamin Herrenschmidt
2012-03-17 23:29 ` Benjamin Herrenschmidt
2012-03-17 23:33 ` Tabi Timur-B04825
2012-03-17 23:33 ` Tabi Timur-B04825
2012-03-18 9:08 ` Grant Likely [this message]
2012-03-18 16:14 ` Tabi Timur-B04825
2012-03-18 16:14 ` Tabi Timur-B04825
2012-03-18 18:22 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120318090804.C70493E060A@localhost \
--to=grant.likely@secretlab.ca \
--cc=B04825@freescale.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.