From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from imr4.ericy.com ([198.24.6.9]:52392 "EHLO imr4.ericy.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751581Ab2CRMQX (ORCPT ); Sun, 18 Mar 2012 08:16:23 -0400 Date: Sun, 18 Mar 2012 05:14:07 -0700 From: Guenter Roeck To: Hans de Goede CC: LM Sensors , Thilo Cestonaro , "linux-watchdog@vger.kernel.org" Subject: Re: [lm-sensors] [PATCH] hwmon/sch56xx: Add support for the integrated watchdog Message-ID: <20120318121407.GA26167@ericsson.com> References: <1331977229-1370-1-git-send-email-hdegoede@redhat.com> <1331977229-1370-2-git-send-email-hdegoede@redhat.com> <20120317185850.GA23351@ericsson.com> <4F65CF2C.4000205@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <4F65CF2C.4000205@redhat.com> Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org Hi Hans, On Sun, Mar 18, 2012 at 08:03:56AM -0400, Hans de Goede wrote: [ ... ] > >> + > >> + data = kzalloc(sizeof(struct sch56xx_watchdog_data), GFP_KERNEL); > >> + if (!data) > >> + return NULL; > >> + One more: You don't include slab.h, which in some configurations results in: /tmp/linux.15278/drivers/hwmon/sch56xx-common.c: In function 'sch56xx_watchdog_release_resources': /tmp/linux.15278/drivers/hwmon/sch56xx-common.c:278: error: implicit declaration of function 'kfree' /tmp/linux.15278/drivers/hwmon/sch56xx-common.c: In function 'sch56xx_watchdog_register': /tmp/linux.15278/drivers/hwmon/sch56xx-common.c:644: error: implicit declaration of function 'kzalloc' /tmp/linux.15278/drivers/hwmon/sch56xx-common.c:644: warning: assignment makes pointer from integer without a cast make[3]: *** [drivers/hwmon/sch56xx-common.o] Error 1 make[3]: *** Waiting for unfinished jobs.... Guenter From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Date: Sun, 18 Mar 2012 12:14:07 +0000 Subject: Re: [lm-sensors] [PATCH] hwmon/sch56xx: Add support for the integrated watchdog Message-Id: <20120318121407.GA26167@ericsson.com> List-Id: References: <1331977229-1370-1-git-send-email-hdegoede@redhat.com> <1331977229-1370-2-git-send-email-hdegoede@redhat.com> <20120317185850.GA23351@ericsson.com> <4F65CF2C.4000205@redhat.com> In-Reply-To: <4F65CF2C.4000205@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Hans de Goede Cc: LM Sensors , Thilo Cestonaro , "linux-watchdog@vger.kernel.org" Hi Hans, On Sun, Mar 18, 2012 at 08:03:56AM -0400, Hans de Goede wrote: [ ... ] > >> + > >> + data = kzalloc(sizeof(struct sch56xx_watchdog_data), GFP_KERNEL); > >> + if (!data) > >> + return NULL; > >> + One more: You don't include slab.h, which in some configurations results in: /tmp/linux.15278/drivers/hwmon/sch56xx-common.c: In function 'sch56xx_watchdog_release_resources': /tmp/linux.15278/drivers/hwmon/sch56xx-common.c:278: error: implicit declaration of function 'kfree' /tmp/linux.15278/drivers/hwmon/sch56xx-common.c: In function 'sch56xx_watchdog_register': /tmp/linux.15278/drivers/hwmon/sch56xx-common.c:644: error: implicit declaration of function 'kzalloc' /tmp/linux.15278/drivers/hwmon/sch56xx-common.c:644: warning: assignment makes pointer from integer without a cast make[3]: *** [drivers/hwmon/sch56xx-common.o] Error 1 make[3]: *** Waiting for unfinished jobs.... Guenter _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors