From: Daniel Vetter <daniel@ffwll.ch>
To: Sean Paul <seanpaul@chromium.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: Add BUG_ON when ring->private is NULL
Date: Sun, 18 Mar 2012 19:09:55 +0100 [thread overview]
Message-ID: <20120318180955.GF4286@phenom.ffwll.local> (raw)
In-Reply-To: <1331916202-20638-2-git-send-email-seanpaul@chromium.org>
On Fri, Mar 16, 2012 at 12:43:21PM -0400, Sean Paul wrote:
> I have experienced a number of NULL pointer dereferences on
> suspend/resume where ring->private is NULL. These come from failed
> initialization of the ring buffer. Sincce this doesn't seem to be easily
> recoverable, this patch adds a BUG_ON and a bread crumb pointer for
> people who might encounter this in the future.
>
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
Chris shot this down on irc, BUG_ON isn't really more useful than a NULL
pointer oops. I agree, so I've dropped this from -next.
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
next prev parent reply other threads:[~2012-03-18 18:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-16 16:43 [PATCH 0/2] Two patches relating to ring initialization failure Sean Paul
2012-03-16 16:43 ` [PATCH 1/2] drm/i915: Add BUG_ON when ring->private is NULL Sean Paul
2012-03-18 18:09 ` Daniel Vetter [this message]
2012-03-18 20:33 ` Sean Paul
2012-03-16 16:43 ` [PATCH 2/2] drm/i915: Add wait_for in init_ring_common Sean Paul
2012-03-16 18:34 ` Ben Widawsky
2012-03-18 17:53 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120318180955.GF4286@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.