From: Dave Jones <davej@redhat.com>
To: richard -rw- weinberger <richard.weinberger@gmail.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [3.3-rc7] sys_poll use after free (hibernate)
Date: Sun, 18 Mar 2012 17:24:44 -0400 [thread overview]
Message-ID: <20120318212443.GA7312@redhat.com> (raw)
In-Reply-To: <CAFLxGvxXBp1+D3Az7onYYvvi9S=_pPLSFpHqOCurjYwTpxbB6w@mail.gmail.com>
On Sun, Mar 18, 2012 at 08:47:19PM +0100, richard -rw- weinberger wrote:
> On Tue, Mar 13, 2012 at 1:58 AM, Dave Jones <davej@redhat.com> wrote:
> > While trying to reproduce the i915 memory corruption problem with hibernate,
>
> If you cannot reproduce the problem you can send me debug/test-patches.
> I have two machines where I can reproduce the issue within an hour.
At the time I was hoping to bisect it. But it looks like it only happens on
ironlake era graphics and newer, which I don't have.
With that info, I'm not sure it's really bisectable. The bug has probably
been there since day 1 when ironlake support was added.
See the thread 'Subject: Re: inode->i_wb_list corruption.' for some further
thoughts, where it's theorised that the GTT contains stale entries after
when we thaw. I wouldn't be surprised if no-one had even tried hibernate
(or at least noticed the memory corruption immediately) before that was merged.
My thinking is that some kind of GTT teardown in the ->hibernate routine is
probably what's needed.
Dave
prev parent reply other threads:[~2012-03-18 21:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-13 0:58 [3.3-rc7] sys_poll use after free (hibernate) Dave Jones
2012-03-18 19:02 ` Linus Torvalds
2012-03-18 19:27 ` Al Viro
2012-03-19 8:17 ` Alexey Dobriyan
2012-03-20 6:08 ` Lucas De Marchi
2012-03-20 18:29 ` [PATCH] sysctl: protect poll() in entries that may go away Lucas De Marchi
2012-03-22 21:31 ` [3.3-rc7] sys_poll use after free (hibernate) Eric W. Biederman
2012-03-22 22:12 ` Lucas De Marchi
2012-03-22 23:02 ` Eric W. Biederman
2012-03-24 0:25 ` [REVIEW][PATCH] Making poll generally useful for sysctls Eric W. Biederman
2012-03-24 6:20 ` Lucas De Marchi
2012-03-24 7:58 ` Eric W. Biederman
2012-03-26 17:44 ` Lucas De Marchi
2012-03-26 17:44 ` Lucas De Marchi
2012-03-27 4:02 ` Lucas De Marchi
2012-03-27 4:02 ` Lucas De Marchi
2012-03-28 2:00 ` Eric W. Biederman
2012-03-22 22:24 ` [3.3-rc7] sys_poll use after free (hibernate) Eric W. Biederman
2012-03-18 19:47 ` richard -rw- weinberger
2012-03-18 21:24 ` Dave Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120318212443.GA7312@redhat.com \
--to=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=richard.weinberger@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.