From: Ted Ts'o <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 3/8] jbd2: Issue cache flush after checkpointing even with internal journal
Date: Sun, 18 Mar 2012 23:45:07 -0400 [thread overview]
Message-ID: <20120319034507.GE31682@thunk.org> (raw)
In-Reply-To: <20120315085935.GA32209@quack.suse.cz>
On Thu, Mar 15, 2012 at 09:59:35AM +0100, Jan Kara wrote:
> On Tue 13-03-12 22:17:45, Ted Tso wrote:
> > I'm not sure why you pulled out the code for
> > jbd2_journal_get_log_tail(), since there's no other usage of the
> > function, but it did make this commit harder to review. It's good for
> > code movement patches to be segregated to their own commit, just to
> > make it easier to review....
> I pulled the code out because the last patch in the series uses it from
> commit code. So it was not a deliberate code movement. But I agree it might
> have been easier to review if the code movement was a separate patch.
> Should I do that or have you already coped with the patch as is?
No, it's fine as it is. I've merged your patches into the ext4 tree
for the upcoming merge window. Thanks!!
Ted
next prev parent reply other threads:[~2012-03-19 3:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-15 18:34 [PATCH 0/8 v3] Checkpointing fixes and cleanups Jan Kara
2012-02-15 18:34 ` [PATCH 1/8] jbd2: Split updating of journal superblock and marking journal empty Jan Kara
2012-02-15 18:34 ` [PATCH 2/8] jbd2: Protect all log tail updates with j_checkpoint_mutex Jan Kara
2012-02-15 18:34 ` [PATCH 3/8] jbd2: Issue cache flush after checkpointing even with internal journal Jan Kara
2012-03-14 2:17 ` Ted Ts'o
2012-03-15 8:59 ` Jan Kara
2012-03-19 3:45 ` Ted Ts'o [this message]
2012-02-15 18:34 ` [PATCH 4/8] jbd2: Fix BH_JWrite setting in checkpointing code Jan Kara
2012-02-15 18:34 ` [PATCH 5/8] jbd2: __jbd2_journal_temp_unlink_buffer() is static Jan Kara
2012-02-15 18:34 ` [PATCH 6/8] jbd2: Remove always true condition in __journal_try_to_free_buffer() Jan Kara
2012-02-15 18:34 ` [PATCH 7/8] jbd2: Remove bh_state lock from checkpointing code Jan Kara
2012-02-15 18:34 ` [PATCH 8/8] jbd2: Cleanup journal tail after transaction commit Jan Kara
2012-02-15 22:03 ` Andreas Dilger
2012-02-16 12:59 ` Jan Kara
2012-02-29 11:03 ` [PATCH 0/8 v3] Checkpointing fixes and cleanups Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120319034507.GE31682@thunk.org \
--to=tytso@mit.edu \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.