From: John Fastabend <john.r.fastabend@intel.com>
To: jhs@mojatatu.com, shemminger@vyatta.com,
bhutchings@solarflare.com, roprabhu@cisco.com,
davem@davemloft.net, jeffrey.t.kirsher@intel.com
Cc: netdev@vger.kernel.org, mst@redhat.com, chrisw@redhat.com,
gregory.v.rose@intel.com, kvm@vger.kernel.org, sri@us.ibm.com,
chealy@imsco-us.com
Subject: [net-next PATCH v0 5/5] ixgbe: allow RAR table to be updated in promisc mode
Date: Sun, 18 Mar 2012 23:52:15 -0700 [thread overview]
Message-ID: <20120319065214.10959.12406.stgit@jf-dev1-dcblab> (raw)
In-Reply-To: <20120319064719.10959.93361.stgit@jf-dev1-dcblab>
This allows RAR table updates while in promiscuous. With
SR-IOV enabled it is valuable to allow the RAR table to
be updated even when in promisc mode to configure forwarding
Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
---
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 21 +++++++++++----------
1 files changed, 11 insertions(+), 10 deletions(-)
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
index 32adb4f..d1925b5 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
@@ -3400,16 +3400,17 @@ void ixgbe_set_rx_mode(struct net_device *netdev)
}
ixgbe_vlan_filter_enable(adapter);
hw->addr_ctrl.user_set_promisc = false;
- /*
- * Write addresses to available RAR registers, if there is not
- * sufficient space to store all the addresses then enable
- * unicast promiscuous mode
- */
- count = ixgbe_write_uc_addr_list(netdev);
- if (count < 0) {
- fctrl |= IXGBE_FCTRL_UPE;
- vmolr |= IXGBE_VMOLR_ROPE;
- }
+ }
+
+ /*
+ * Write addresses to available RAR registers, if there is not
+ * sufficient space to store all the addresses then enable
+ * unicast promiscuous mode
+ */
+ count = ixgbe_write_uc_addr_list(netdev);
+ if (count < 0) {
+ fctrl |= IXGBE_FCTRL_UPE;
+ vmolr |= IXGBE_VMOLR_ROPE;
}
if (adapter->num_vfs) {
next prev parent reply other threads:[~2012-03-19 7:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-19 6:51 [net-next PATCH v0 0/5] Series short description John Fastabend
2012-03-19 6:51 ` [net-next PATCH v0 2/5] net: addr_list: add exclusive dev_uc_add John Fastabend
2012-03-25 13:07 ` Roopa Prabhu
2012-03-19 6:52 ` [net-next PATCH v0 3/5] net: add fdb generic dump routine John Fastabend
2012-03-25 13:09 ` Roopa Prabhu
2012-03-26 21:41 ` John Fastabend
2012-03-19 6:52 ` [net-next PATCH v0 4/5] ixgbe: enable FDB netdevice ops John Fastabend
2012-03-19 22:46 ` Jeff Kirsher
2012-03-19 6:52 ` John Fastabend [this message]
2012-03-19 22:44 ` [net-next PATCH v0 5/5] ixgbe: allow RAR table to be updated in promisc mode Jeff Kirsher
2012-03-19 22:38 ` [net-next PATCH v0 0/5] Series short description David Miller
2012-03-19 22:55 ` Stephen Hemminger
2012-03-20 0:27 ` John Fastabend
2012-03-20 0:35 ` David Miller
2012-03-20 2:49 ` John Fastabend
2012-03-20 2:51 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120319065214.10959.12406.stgit@jf-dev1-dcblab \
--to=john.r.fastabend@intel.com \
--cc=bhutchings@solarflare.com \
--cc=chealy@imsco-us.com \
--cc=chrisw@redhat.com \
--cc=davem@davemloft.net \
--cc=gregory.v.rose@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jhs@mojatatu.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=roprabhu@cisco.com \
--cc=shemminger@vyatta.com \
--cc=sri@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.