All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gleb Natapov <gleb@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Alex Williamson <alex.williamson@redhat.com>,
	qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [Qemu-devel] [PATCH 0/2] acpi: robust notifications
Date: Mon, 19 Mar 2012 10:28:40 +0200	[thread overview]
Message-ID: <20120319082840.GL27306@redhat.com> (raw)
In-Reply-To: <cover.1332089914.git.mst@redhat.com>

On Sun, Mar 18, 2012 at 07:06:23PM +0200, Michael S. Tsirkin wrote:
> acpi currently clears up/down registers on each hotplug
> request. This loses events if they are done quickly.
> It's easy to clear down on ej write.
> To detect that guest was notified of device addition,
> we track configuration accesses since system reset.
> 
This is hack. This is not how real HW works, why do we needed it?
If up/down thing is so broken that this is required lets move to how
cpu hot-plug works and maintain slot status bit map instead. BTW
we discussed that with Alex last week. Have you followed that thread.

> Michael S. Tsirkin (2):
>   pci: track function accesses
>   acpi: don't clear up/down on each host change
> 
>  hw/acpi_piix4.c |   32 +++++++++++++++++++++++++++-----
>  hw/pci.c        |   26 ++++++++++++++++++++++++++
>  hw/pci.h        |    3 +++
>  hw/pci_host.c   |    2 ++
>  4 files changed, 58 insertions(+), 5 deletions(-)
> 
> -- 
> 1.7.9.111.gf3fb0

--
			Gleb.

      parent reply	other threads:[~2012-03-19  8:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-18 17:06 [Qemu-devel] [PATCH 0/2] acpi: robust notifications Michael S. Tsirkin
2012-03-18 17:06 ` [Qemu-devel] [PATCH 1/2] pci: track function accesses Michael S. Tsirkin
2012-03-18 17:06 ` [Qemu-devel] [PATCH 2/2] acpi: don't clear up/down on each host change Michael S. Tsirkin
2012-03-19  8:28 ` Gleb Natapov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120319082840.GL27306@redhat.com \
    --to=gleb@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.