All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Thomas Klute <thomas2.klute@uni-dortmund.de>
Cc: linux-omap@vger.kernel.org
Subject: Re: smsc911x on Gumstix Overo/Tobi doesn't work
Date: Mon, 19 Mar 2012 15:51:31 -0700	[thread overview]
Message-ID: <20120319225131.GE9859@atomide.com> (raw)
In-Reply-To: <4F675D9D.2040102@uni-dortmund.de>

* Thomas Klute <thomas2.klute@uni-dortmund.de> [120319 09:26]:
> Am 16.03.2012 20:33, schrieb Tony Lindgren:
> > Hi,
> > 
> > * Thomas Klute <thomas2.klute@uni-dortmund.de> [120316 05:08]:
> >> Hi,
> >>
> >> I have trouble getting the Ethernet port on a Gumstix Overo with Tobi
> >> expansion board to work with current kernel versions. With the latest
> >> commit from linux-omap git (b8fe1781ec8bed5e086691a827a6ee11facec2aa),
> >> the output from loading the smsc911x driver is as follows:
> >>
> >> du14:~# modprobe smsc911x
> >> [  254.843811] smsc911x: Driver version 2008-10-21
> >> [  254.854553] smsc911x: Driver version 2008-10-21
> >> [  254.859588] _regulator_get: smsc911x.1 supply vdd33a not found, using
> >> dummy regulator
> >> [  254.868377] _regulator_get: smsc911x.1 supply vddvario not found,
> >> using dummy regulator
> >>
> >> "ip link show" does not show any available Ethernet port.
> > 
> > The first instance one should work the same way as earlier using
> > fixed regulator in gpmc-smsc911x.c. Is it not working for you
> > somehow? At least it works for me on zoom3.
> 
> The Tobi board has only one Ethernet port.
> 
> >> I know there has been some trouble with changes around smsc911x
> >> regulator support and Gumstix Overo in particular. Am I just missing the
> >> right regulator in my kernel config or is this a bug? I can test patches
> >> in the latter case.
> > 
> > The second smsc911x now needs a regulator. For multiple smsc911x instances,
> > we should change things around so no regulator is created if one
> > is passed.
> > 
> > Care to test the following patch by passing a fixed regulator
> > from board-overo.c?
> 
> After applying the patch the Ethernet port works consistently once I had
> done a cold boot (reboot from the unpatched kernel did not work).
> Thank you!

Hmm but this patch should not change the behaviour for the first smsc911x
instance unless you specify a custom regulator.. Did you patch in a
custom regulator, or do we have a bug somewhere? Or do you just need to
do a cold reset without the patch I posted?
 
> However, I noticed another problem while testing the patch (not sure if
> it occurs with the previous version, I can check if that helps): A NULL
> pointer dereference occurs when unloading the module, see attached log.

Yes please do check, that needs to be fixed.

Regards,

Tony

  reply	other threads:[~2012-03-19 22:51 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-16 11:32 smsc911x on Gumstix Overo/Tobi doesn't work Thomas Klute
2012-03-16 19:33 ` Tony Lindgren
2012-03-19 16:23   ` Thomas Klute
2012-03-19 22:51     ` Tony Lindgren [this message]
2012-03-20 14:27       ` Thomas Klute
2012-03-20 19:47         ` Javier Martinez Canillas
2012-03-21 16:29           ` Thomas Klute
2012-03-30 15:28           ` Thomas Klute
2012-04-01 19:20             ` Javier Martinez Canillas
2012-05-02 11:42               ` Thomas Klute
2012-05-03 11:09                 ` Javier Martinez Canillas
2012-05-09 11:47                   ` Thomas Klute
2012-03-21 17:55 ` [PATCH] [RFC] Correct registration of multiple gpmc smsc911x devices Russ Dill
2012-03-21 18:13   ` Mark Brown
2012-03-21 18:18     ` Porter, Matt
2012-03-21 18:24     ` Porter, Matt
2012-03-21 18:39       ` Tony Lindgren
2012-03-21 19:00         ` Mark Brown
2012-03-21 19:30           ` Tony Lindgren
2012-03-21 19:38             ` Mark Brown
2012-03-21 19:41               ` Tony Lindgren
2012-03-21 20:45                 ` Russ Dill
2012-03-22  5:19                 ` [PATCH 00/13] Fixup gmpc smsc911x regulator handling Russ Dill
2012-03-22  5:19                   ` [PATCH 01/13] Remove odd gpmc_cfg/board_data redirection Russ Dill
2012-03-22  5:19                   ` [PATCH 02/13] Fix possible stale smsc911x flags Russ Dill
2012-03-22  5:19                   ` [PATCH 03/13] Remove unused rate calculation Russ Dill
2012-03-22  5:19                   ` [PATCH 04/13] Remove non-existent parameter from fixed-helper.c kernel doc Russ Dill
2012-03-22 11:36                     ` Mark Brown
2012-03-22 18:30                       ` Russ Dill
2012-03-22  5:19                   ` [PATCH 05/13] Remove regulator support from gmpc-smsc911x Russ Dill
2012-03-22  5:19                   ` [PATCH 06/13] Add dummy smsc911x regulators to cm-t35 Russ Dill
2012-03-22  5:19                   ` [PATCH 07/13] Add dummy smsc911x regulators to igep0020 Russ Dill
2012-03-22  5:19                   ` [PATCH 08/13] Add dummy smsc911x regulators to ldp Russ Dill
2012-03-22  7:06                     ` Koen Kooi
2012-03-22  5:19                   ` [PATCH 09/13] Add dummy smsc911x regulators to omap3evm Russ Dill
2012-03-22  7:07                     ` Koen Kooi
2012-03-22  7:16                       ` Russ Dill
2012-03-22  5:19                   ` [PATCH 10/13] Add dummy smsc911x regulators to omap3logic Russ Dill
2012-03-22  5:19                   ` [PATCH 11/13] Add dummy smsc911x regulators to omap3stalker Russ Dill
2012-03-22  5:19                   ` [PATCH 12/13] Add dummy smsc911x regulators to overo Russ Dill
2012-03-22  5:19                   ` [PATCH 13/13] Add dummy smsc911x regulators to zoom-debugboard Russ Dill
2012-03-22 11:37                     ` Mark Brown
2012-03-22 18:29                       ` Russ Dill
2012-03-23  8:49                         ` Igor Grinberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120319225131.GE9859@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=thomas2.klute@uni-dortmund.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.