From: Dave Jones <davej@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: venkat.x.venkatsubra@oracle.com, netdev@vger.kernel.org
Subject: Remove printk from rds_sendmsg
Date: Mon, 19 Mar 2012 19:01:07 -0400 [thread overview]
Message-ID: <20120319230107.GA23987@redhat.com> (raw)
In-Reply-To: <20120319.184335.1229962428916453634.davem@davemloft.net>
no socket layer outputs a message for this error and neither should rds.
Signed-off-by: Dave Jones <davej@redhat.com>
--- linux/net/rds/send.c 2011-11-07 12:00:32.000000000 -0500
+++ linux/net/rds/send.c 2012-03-19 18:59:55.905890597 -0400
@@ -935,7 +935,6 @@ int rds_sendmsg(struct kiocb *iocb, stru
/* Mirror Linux UDP mirror of BSD error message compatibility */
/* XXX: Perhaps MSG_MORE someday */
if (msg->msg_flags & ~(MSG_DONTWAIT | MSG_CMSG_COMPAT)) {
- printk(KERN_INFO "msg_flags 0x%08X\n", msg->msg_flags);
ret = -EOPNOTSUPP;
goto out;
}
next prev parent reply other threads:[~2012-03-19 23:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-19 22:40 Improve rds_sendmsg printk Dave Jones
2012-03-19 22:43 ` David Miller
2012-03-19 23:01 ` Dave Jones [this message]
2012-03-20 20:12 ` Remove printk from rds_sendmsg David Miller
2012-03-20 14:50 ` Improve rds_sendmsg printk Venkat Venkatsubra
2012-03-19 23:08 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120319230107.GA23987@redhat.com \
--to=davej@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=venkat.x.venkatsubra@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.