From: Al Viro <viro@ZenIV.linux.org.uk>
To: Mike Frysinger <vapier@gentoo.org>
Cc: Duane Griffin <duaneg@dghda.com>,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: umode_t breakage in exported kernel headers
Date: Tue, 20 Mar 2012 10:05:10 +0000 [thread overview]
Message-ID: <20120320100510.GK6589@ZenIV.linux.org.uk> (raw)
In-Reply-To: <201203191601.55668.vapier@gentoo.org>
On Mon, Mar 19, 2012 at 04:01:53PM -0400, Mike Frysinger wrote:
> commit 0583fcc96bb117763c0fa74c123573c0112dec65 moved umode_t out of the
> exported headers space (via the arches' asm/types.h) and into __KERNEL__
> specific linux/types.h. this breaks the exported linux/ext2_fs.h
> ext2_mask_flags function which uses that type. that func appears to be the
> only one exported that utilizes umode_t.
>
> should ext2_mask_flags be updated to take a __kernel_mode_t as its first arg ?
> -mike
ITYM "unsigned short". __kernel_mode_t is wrong kernel-side and pointless
everywhere. It should *only* be used in layout of structs shared with
userland and misdefined back then. Anything new should use explicitly-sized
types (and u16 is enough for mode).
It's nearly entirely about ncp_mount_data - ipc_perm, ipc64_perm and in
several cases st_mode of stat* are arch-dependent anyway and could bloody
well use explicitly-sized types.
prev parent reply other threads:[~2012-03-20 10:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-19 20:01 umode_t breakage in exported kernel headers Mike Frysinger
2012-03-20 10:05 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120320100510.GK6589@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=duaneg@dghda.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.