From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 4/5] drm/i915: Remove the deferred-free list Date: Tue, 20 Mar 2012 14:38:51 +0100 Message-ID: <20120320133851.GA27231@phenom.ffwll.local> References: <1330118022-5701-1-git-send-email-chris@chris-wilson.co.uk> <1330118022-5701-5-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-we0-f177.google.com (mail-we0-f177.google.com [74.125.82.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 31ABF9E9FD for ; Tue, 20 Mar 2012 06:38:13 -0700 (PDT) Received: by werp11 with SMTP id p11so36445wer.36 for ; Tue, 20 Mar 2012 06:38:12 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Feb 24, 2012 at 09:30:33PM +0000, Chris Wilson wrote: > On Fri, 24 Feb 2012 21:13:41 +0000, Chris Wilson wrote: > > The use of the mm_list by deferred-free breaks the following patches to > > extend the range of objects tracked. We can simplify things if we just > > make the unbind during free uninterrible. > > Darn it, this *was* two patches before I fluffed the rebase. I haven't looked much at the patch, but the deferred-free looks more bogus the more I stare at it. As long as an object is active, we /should/ have a reference on it, so we should never fail to wait for outstanding rendering on the final free. The only execption is the ilk/vt-d unbind w/a, but that one is already uninterruptible. So I think we should just drop the deferred free list, check for any errors from unbind with a WARN_ON and bail out (leaking the bo) in that case. -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48