From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH 07/10] cgroup: remove cgroup_add_file[s]() Date: Tue, 20 Mar 2012 09:01:21 -0700 Message-ID: <20120320160121.GC5684@google.com> References: <1331940963-15756-1-git-send-email-tj@kernel.org> <1331940963-15756-8-git-send-email-tj@kernel.org> <87aa3bu094.fsf@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=KKh65ED/EWlgqvzfPvslt34Qoxjo2duU69366i9QKqc=; b=h7IpAWkQ20t38lZ97dQvSy1KS5srKSAtZAEg/g921fkUn+WUNjnLI4Wj67S5n1ww3p EELb/gbU6qhilAW94xfnrn2jgR/53tlxTXmHmi6+0cnzQlLu5enCH/NFDSGjBmbcZ/wc BUxUntkdYrYHv7r18t2PmGErXjS9a1+tiMmVb/hL1jbPFB9tsV95qG1ZtzRDw6VTryYb ZzZO41yQVDD2dDcFaJDTZuxFZyZULDsyzSSYEACQowSb5w4SWg/GsT3vuTcgEKsDa3Nr +q7WNuzSmTJYFmoX4iBGiohtb1RUyozdP6mSdJy9r13hFBZAMqkG1G9viFxZ1lGnM3aU 7Gug== Content-Disposition: inline In-Reply-To: <87aa3bu094.fsf-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: "Aneesh Kumar K.V" Cc: ctalbott-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, rni-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, fweisbec-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On Tue, Mar 20, 2012 at 02:17:51PM +0530, Aneesh Kumar K.V wrote: > Tejun Heo writes: > > > No controller is using cgroup_add_files[s](). Unexport them, and > > convert cgroup_add_files() to handle NULL entry terminated array > > instead of taking count explicitly and continue creation on failure > > for internal use. > > > > I am planning to use that in the HugeTLB extension of memcg. > > http://article.gmane.org/gmane.linux.kernel.mm/75470 > > We need to have different limit and usage file for different HugeTLB > page size supported. Unless you have to alter available files cgroup-by-cgroup, you should be fine. If you're trying to create different set of files depending on cgroup, it's confusing - change your interface. Thanks. -- tejun From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760703Ab2CTQBb (ORCPT ); Tue, 20 Mar 2012 12:01:31 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:39265 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756186Ab2CTQB3 (ORCPT ); Tue, 20 Mar 2012 12:01:29 -0400 Date: Tue, 20 Mar 2012 09:01:21 -0700 From: Tejun Heo To: "Aneesh Kumar K.V" Cc: glommer@parallels.com, lizf@cn.fujitsu.com, containers@lists.linux-foundation.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, fweisbec@gmail.com, rni@google.com, ctalbott@google.com Subject: Re: [PATCH 07/10] cgroup: remove cgroup_add_file[s]() Message-ID: <20120320160121.GC5684@google.com> References: <1331940963-15756-1-git-send-email-tj@kernel.org> <1331940963-15756-8-git-send-email-tj@kernel.org> <87aa3bu094.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87aa3bu094.fsf@linux.vnet.ibm.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 20, 2012 at 02:17:51PM +0530, Aneesh Kumar K.V wrote: > Tejun Heo writes: > > > No controller is using cgroup_add_files[s](). Unexport them, and > > convert cgroup_add_files() to handle NULL entry terminated array > > instead of taking count explicitly and continue creation on failure > > for internal use. > > > > I am planning to use that in the HugeTLB extension of memcg. > > http://article.gmane.org/gmane.linux.kernel.mm/75470 > > We need to have different limit and usage file for different HugeTLB > page size supported. Unless you have to alter available files cgroup-by-cgroup, you should be fine. If you're trying to create different set of files depending on cgroup, it's confusing - change your interface. Thanks. -- tejun