* [patch] aio: change a stray spin_unlock_bh() to spin_unlock()
@ 2012-03-20 13:09 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2012-03-20 13:09 UTC (permalink / raw)
To: Alexander Viro
Cc: Benjamin LaHaise, linux-fsdevel, linux-aio, kernel-janitors
We missed this spin_unlock_bh() when we removed the _bh from the other
locks in cb22bbe9f7 "aio: aio_nr_lock is taken only synchronously now"
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/fs/aio.c b/fs/aio.c
index 7b6b9d5..4f71627 100644
--- a/fs/aio.c
+++ b/fs/aio.c
@@ -280,7 +280,7 @@ static struct kioctx *ioctx_alloc(unsigned nr_events)
spin_lock(&aio_nr_lock);
if (aio_nr + nr_events > aio_max_nr ||
aio_nr + nr_events < aio_nr) {
- spin_unlock_bh(&aio_nr_lock);
+ spin_unlock(&aio_nr_lock);
goto out_cleanup;
}
aio_nr += ctx->max_reqs;
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [patch] aio: change a stray spin_unlock_bh() to spin_unlock()
@ 2012-03-20 13:09 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2012-03-20 13:09 UTC (permalink / raw)
To: Alexander Viro
Cc: Benjamin LaHaise, linux-fsdevel, linux-aio, kernel-janitors
We missed this spin_unlock_bh() when we removed the _bh from the other
locks in cb22bbe9f7 "aio: aio_nr_lock is taken only synchronously now"
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/fs/aio.c b/fs/aio.c
index 7b6b9d5..4f71627 100644
--- a/fs/aio.c
+++ b/fs/aio.c
@@ -280,7 +280,7 @@ static struct kioctx *ioctx_alloc(unsigned nr_events)
spin_lock(&aio_nr_lock);
if (aio_nr + nr_events > aio_max_nr ||
aio_nr + nr_events < aio_nr) {
- spin_unlock_bh(&aio_nr_lock);
+ spin_unlock(&aio_nr_lock);
goto out_cleanup;
}
aio_nr += ctx->max_reqs;
--
To unsubscribe, send a message with 'unsubscribe linux-aio' in
the body to majordomo@kvack.org. For more info on Linux AIO,
see: http://www.kvack.org/aio/
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [patch] aio: change a stray spin_unlock_bh() to spin_unlock()
2012-03-20 13:09 ` Dan Carpenter
@ 2012-03-20 19:13 ` Al Viro
-1 siblings, 0 replies; 4+ messages in thread
From: Al Viro @ 2012-03-20 19:13 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Benjamin LaHaise, linux-fsdevel, linux-aio, kernel-janitors
On Tue, Mar 20, 2012 at 04:09:19PM +0300, Dan Carpenter wrote:
> We missed this spin_unlock_bh() when we removed the _bh from the other
> locks in cb22bbe9f7 "aio: aio_nr_lock is taken only synchronously now"
Nice catch; folded into the offending commit
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] aio: change a stray spin_unlock_bh() to spin_unlock()
@ 2012-03-20 19:13 ` Al Viro
0 siblings, 0 replies; 4+ messages in thread
From: Al Viro @ 2012-03-20 19:13 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Benjamin LaHaise, linux-fsdevel, linux-aio, kernel-janitors
On Tue, Mar 20, 2012 at 04:09:19PM +0300, Dan Carpenter wrote:
> We missed this spin_unlock_bh() when we removed the _bh from the other
> locks in cb22bbe9f7 "aio: aio_nr_lock is taken only synchronously now"
Nice catch; folded into the offending commit
--
To unsubscribe, send a message with 'unsubscribe linux-aio' in
the body to majordomo@kvack.org. For more info on Linux AIO,
see: http://www.kvack.org/aio/
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-03-20 19:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-20 13:09 [patch] aio: change a stray spin_unlock_bh() to spin_unlock() Dan Carpenter
2012-03-20 13:09 ` Dan Carpenter
2012-03-20 19:13 ` Al Viro
2012-03-20 19:13 ` Al Viro
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.