All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
To: Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>
Cc: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>,
	Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
	Jamie Lentin <jm-Pj/HzkgeCk7QXOPxS62xeg@public.gmane.org>,
	Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>,
	michael-QKn5cuLxLXY@public.gmane.org,
	devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	Grant Likely
	<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: kirkwood devicetree respin
Date: Tue, 20 Mar 2012 21:45:04 +0100	[thread overview]
Message-ID: <20120320204504.GE8315@lunn.ch> (raw)
In-Reply-To: <20120320194449.GH2484-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org>

> > Hi Jason
> > 
> > I fell fowl of something in this area. Do you have CONFIG_USB_EHCI_MV=y?
> > Make sure you do not have this. 
> > 
> > drivers/usb/host/ehci-hcd.c has some unusual code, and if you have
> > both CONFIG_USB_EHCI_MV and CONFIG_PLAT_ORION, the CONFIG_USB_EHCI_MV
> > is given preference and the Orion driver never gets its probe
> > functions called etc.
> 
> waddaya know?  The compile warnings went away, and the d*mn thing booted
> fine.
> 
> Is there a scenario where someone would want to select
> CONFIG_USB_EHCI_MV in menuconfig?

Not on an Orion platform, as far as i know. Maybe

config USB_EHCI_MV
        bool "EHCI support for Marvell on-chip controller"
-        depends on USB_EHCI_HCD
+        depends on USB_EHCI_HCD && !PLAT_ORION
        select USB_EHCI_ROOT_HUB_TT
        ---help---
          Enables support for Marvell (including PXA and MMP series) on-chip
          USB SPH and OTG controller. SPH is a single port host, and it can
          only be EHCI host. OTG is controller that can switch to host mode.

Maybe also -Werror for that one file to catch other similar cases?

Andrew

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2012-03-20 20:45 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20120312214325.GD5050@titan.lakedaemon.net>
     [not found] ` <20120312214325.GD5050-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org>
2012-03-13 15:57   ` kirkwood devicetree respin Arnd Bergmann
     [not found]     ` <201203131557.49488.arnd-r2nGTMty4D4@public.gmane.org>
2012-03-13 16:00       ` Arnd Bergmann
2012-03-13 16:44       ` Jason Cooper
2012-03-15  2:22       ` Jason Cooper
2012-03-20 17:22       ` Jason Cooper
     [not found]         ` <20120320172238.GC2484-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org>
2012-03-20 18:03           ` Nicolas Pitre
     [not found]             ` <alpine.LFD.2.02.1203201401410.24151-QuJgVwGFrdf/9pzu0YdTqQ@public.gmane.org>
2012-03-20 18:24               ` Jason Cooper
     [not found]                 ` <20120320182459.GD2484-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org>
2012-03-20 19:03                   ` Nicolas Pitre
     [not found]                     ` <alpine.LFD.2.02.1203201454540.24151-QuJgVwGFrdf/9pzu0YdTqQ@public.gmane.org>
2012-03-20 19:16                       ` Jason Cooper
2012-03-20 19:15           ` Arnd Bergmann
     [not found]             ` <201203201915.08317.arnd-r2nGTMty4D4@public.gmane.org>
2012-03-20 19:32               ` Andrew Lunn
     [not found]                 ` <20120320193222.GD8315-g2DYL2Zd6BY@public.gmane.org>
2012-03-20 19:44                   ` Jason Cooper
     [not found]                     ` <20120320194449.GH2484-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org>
2012-03-20 20:45                       ` Andrew Lunn [this message]
     [not found]                         ` <20120320204504.GE8315-g2DYL2Zd6BY@public.gmane.org>
2012-03-20 20:57                           ` Arnd Bergmann
     [not found]                             ` <201203202057.38365.arnd-r2nGTMty4D4@public.gmane.org>
2012-03-20 22:01                               ` Jason Cooper
     [not found]                                 ` <20120320220156.GI2484-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org>
2012-03-20 22:15                                   ` Arnd Bergmann
     [not found]                                     ` <201203202215.09227.arnd-r2nGTMty4D4@public.gmane.org>
2012-03-20 23:06                                       ` Jason Cooper
2012-03-21  3:54                                       ` Nicolas Pitre
     [not found]                                         ` <alpine.LFD.2.02.1203202348150.24151-QuJgVwGFrdf/9pzu0YdTqQ@public.gmane.org>
2012-03-21  8:21                                           ` Haojian Zhuang
     [not found]                                             ` <CAN1soZymEsMiivL_76o_g+-P1HhLx72Z2vbV3HBDs0x+oeWn+w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-03-21  8:34                                               ` Andrew Lunn
     [not found]                                                 ` <20120321083428.GA25111-g2DYL2Zd6BY@public.gmane.org>
2012-03-21  8:42                                                   ` Haojian Zhuang
     [not found]                                                     ` <CAN1soZyObqAPq=fhn8eB1z0aYqTs87oNBsF_AXbo6kq9fpvhMA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-03-21 10:09                                                       ` Arnd Bergmann
     [not found]                                                         ` <201203211009.40934.arnd-r2nGTMty4D4@public.gmane.org>
2012-03-21 11:45                                                           ` Felipe Balbi
     [not found]                                                             ` <20120321114546.GC3092-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2012-03-21 13:17                                                               ` Arnd Bergmann
     [not found]                                                                 ` <201203211317.38339.arnd-r2nGTMty4D4@public.gmane.org>
2012-03-21 13:22                                                                   ` Felipe Balbi
     [not found]                                                                     ` <20120321132230.GL3092-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2012-03-21 20:06                                                                       ` Paul Zimmerman
     [not found]                                                                         ` <A2CA0424C0A6F04399FB9E1CD98E0304090B77CA-Yu2iAY70zvrYN67daEjeMPufCSb+aD3WLzEdoUbNIic@public.gmane.org>
2012-03-22  8:13                                                                           ` Felipe Balbi
     [not found]                                                                             ` <20120322081315.GG31160-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2012-03-22 18:28                                                                               ` Paul Zimmerman
     [not found]                                                                                 ` <A2CA0424C0A6F04399FB9E1CD98E0304090B7F02-Yu2iAY70zvrYN67daEjeMPufCSb+aD3WLzEdoUbNIic@public.gmane.org>
2012-03-27  9:05                                                                                   ` Felipe Balbi
     [not found]                                                                                     ` <20120327090518.GL7379-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2012-03-27 17:40                                                                                       ` Paul Zimmerman
2012-03-21 13:36                                           ` EHCI_MV confusion was: " Jason Cooper
     [not found]                                             ` <20120321133609.GK2484-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org>
2012-03-21 13:56                                               ` Alan Stern
     [not found]                                                 ` <Pine.LNX.4.44L0.1203210955140.1369-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-03-21 15:12                                                   ` Jason Cooper
2012-03-21 16:18                                                   ` Nicolas Pitre
     [not found]                                                     ` <alpine.LFD.2.02.1203211216010.24151-QuJgVwGFrdf/9pzu0YdTqQ@public.gmane.org>
2012-03-21 16:27                                                       ` Alan Stern
     [not found]                                                         ` <Pine.LNX.4.44L0.1203211226310.1369-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-03-22  1:39                                                           ` Neil Zhang
2012-03-20 19:33               ` Jason Cooper
2012-04-06 23:20       ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120320204504.GE8315@lunn.ch \
    --to=andrew-g2dyl2zd6by@public.gmane.org \
    --cc=arnd-r2nGTMty4D4@public.gmane.org \
    --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \
    --cc=jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org \
    --cc=jm-Pj/HzkgeCk7QXOPxS62xeg@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=michael-QKn5cuLxLXY@public.gmane.org \
    --cc=olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.