All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrea Arcangeli <aarcange@redhat.com>
To: Hillf Danton <dhillf@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] autonuma: release page_table_lock in scanning pmd
Date: Tue, 20 Mar 2012 22:17:24 +0100	[thread overview]
Message-ID: <20120320211723.GG24602@redhat.com> (raw)
In-Reply-To: <CAJd=RBAjXi04AwyCS94xFZkKNWv3ngKw=04Jw+Y9nNnMXjH-WQ@mail.gmail.com>

On Tue, Mar 20, 2012 at 08:30:48PM +0800, Hillf Danton wrote:
> Only for unlikely corner case, unlock is added to pair lock.
> 
> Signed-off-by: Hillf Danton <dhillf@gmail.com>
> ---
> 
> --- a/mm/autonuma.c	Sat Mar 17 11:01:50 2012
> +++ b/mm/autonuma.c	Tue Mar 20 19:58:44 2012
> @@ -522,7 +522,8 @@ static int knumad_scan_pmd(struct mm_str
>  				spin_unlock(&mm->page_table_lock);
>  				goto out;
>  			}
> -		}
> +		} else
> +			spin_unlock(&mm->page_table_lock);
>  	}
> 
>  	VM_BUG_ON(!pmd_present(*pmd));

I'm impressed by how fast you found these bugs.

Thanks a lot, applied!
Andrea

      reply	other threads:[~2012-03-20 21:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-20 12:30 [PATCH] autonuma: release page_table_lock in scanning pmd Hillf Danton
2012-03-20 21:17 ` Andrea Arcangeli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120320211723.GG24602@redhat.com \
    --to=aarcange@redhat.com \
    --cc=dhillf@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.