All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Bernhard Walle <walle@corscience.de>
Cc: sameo@linux.intel.com, linux-kernel@vger.kernel.org,
	linux-omap@vger.kernel.org
Subject: Re: [PATCH] mfd: Add TWL4030 PWM driver
Date: Tue, 20 Mar 2012 22:02:11 +0000	[thread overview]
Message-ID: <201203202202.12060.arnd@arndb.de> (raw)
In-Reply-To: <1332262083-9375-1-git-send-email-walle@corscience.de>

On Tuesday 20 March 2012, Bernhard Walle wrote:
> 
> This PWM driver uses the PWM of the TWL4030. The driver for the TWL6030
> PWM has been used as mode, but the PWM registers are different.
> 
> The driver can be used and has been tested in conjunction with
> pwm-backlight to control a backlight LED of a LCD touch screen.
> 
> Signed-off-by: Bernhard Walle <walle@corscience.de>

Since it's too late for v3.4 now and we will get a new pwm
subsystem in v3.5, I suggest you change the driver to work
register with that subsystem instead of just using the old
header file. Note that drivers/mfd is not really the right
place anyway, because this is not a multifunction driver but
just one device driver that happens to be a slave of an mfd.

	Arnd

  reply	other threads:[~2012-03-20 22:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-20 16:48 [PATCH] mfd: Add TWL4030 PWM driver Bernhard Walle
2012-03-20 22:02 ` Arnd Bergmann [this message]
2012-03-21  6:15   ` Bernhard Walle
2012-03-21  6:15     ` Bernhard Walle
2012-03-21  8:39     ` Arnd Bergmann
2012-03-21  8:48       ` Thierry Reding
2012-03-21 10:03         ` Arnd Bergmann
2012-03-21 10:28           ` Thierry Reding
2012-03-21 11:31             ` Sascha Hauer
2012-03-21 16:55 ` Grazvydas Ignotas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201203202202.12060.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    --cc=walle@corscience.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.