Re: [Qemu-devel] [PATCH] Fix typo in i400FX chipset init code

["Michael S. Tsirkin" <mst@redhat.com>]

On Wed, Feb 29, 2012 at 02:35:14PM +1300, Alexey Korolev wrote:
> Hi,
> 
> There is a typo in i440FX init code. This is causing problems when
> somebody wants to access 64bit PCI range.
> 
> 
> Signed-off-by: Alexey Korolev <alexey.korolev@endace.com>

I've fixed the commit message and applied.
How does one trigger the problem?
I'd like to know so I can test for it.

> ---
> 
>  hw/piix_pci.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/hw/piix_pci.c b/hw/piix_pci.c
> index 3ed3d90..aab8188 100644
> --- a/hw/piix_pci.c
> +++ b/hw/piix_pci.c
> @@ -353,7 +353,7 @@ PCIBus *i440fx_init(PCII440FXState **pi440fx_state, int *piix3_devfn,
>      b = i440fx_common_init("i440FX", pi440fx_state, piix3_devfn, isa_bus, pic,
>                             address_space_mem, address_space_io, ram_size,
>                             pci_hole_start, pci_hole_size,
> -                           pci_hole64_size, pci_hole64_size,
> +                           pci_hole64_start, pci_hole64_size,
>                             pci_memory, ram_memory);
>      return b;
>  }
> 
> 
> 
>