From: Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Sachin Prabhu <sprabhu-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] cifs: use standard token parser for mount options
Date: Wed, 21 Mar 2012 13:38:55 -0400 [thread overview]
Message-ID: <20120321133855.52901c60@redhat.com> (raw)
In-Reply-To: <1331307197.10670.2.camel@localhost>
On Fri, 09 Mar 2012 15:33:17 +0000
Sachin Prabhu <sprabhu-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
> Use the standard token parser instead of the long if confidtion to parse
> cifs mount options.
>
> This was first proposed by Scott Lovenberg
> http://lists.samba.org/archive/linux-cifs-client/2010-May/006079.html
>
> Mount options have been grouped together in terms of their input types.
> Aliases for username, password, domain and credentials have been added.
> The password parser has been modified to make it easier to read.
>
> Signed-off-by: Sachin Prabhu <sprabhu-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>
In testing this today, I found a problem. I tried to mount up a share
with sec=none as the options. With that, I got this error:
CIFS: Unknown mount option pass=
The problem is that the mount.cifs helper will pass a blank "pass="
option to the kernel. It seems like the standard option parser doesn't
have a way to allow you to specify an optional argument. That may need
to be added in order for this to work.
--
Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
next prev parent reply other threads:[~2012-03-21 17:38 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-09 15:33 [PATCH] cifs: use standard token parser for mount options Sachin Prabhu
[not found] ` <CAFB9KM0AMO_r0W2grCk2MRfZ9bVf+J5pbP1Yexxw46dacoYynw@mail.gmail.com>
[not found] ` <CAFB9KM0AMO_r0W2grCk2MRfZ9bVf+J5pbP1Yexxw46dacoYynw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-03-09 16:16 ` Scott Lovenberg
[not found] ` <4F5A2CCD.6010808-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-03-14 18:17 ` Sachin Prabhu
[not found] ` <24dc471d-42ca-45cf-89eb-26dc3117fa1a-s/U0J+63Ool+R5eDjrG6zsCp5Q1pQRjfhaY/URYTgi6ny3qCrzbmXA@public.gmane.org>
2012-03-14 19:18 ` Jeff Layton
[not found] ` <20120314151811.65838f6b-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-03-14 19:30 ` Steve French
[not found] ` <CAH2r5muUm-E5n6Le4JPnBZmKNJ46OJ8dYZdS9b79=O3UGif4Rg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-03-14 19:43 ` Scott Lovenberg
[not found] ` <4F60F4E3.5010003-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-03-14 19:46 ` Scott Lovenberg
2012-03-14 19:58 ` Sachin Prabhu
[not found] ` <90445c03-bbcc-4faf-afbf-fde4b1d17f05-s/U0J+63Ool+R5eDjrG6zsCp5Q1pQRjfhaY/URYTgi6ny3qCrzbmXA@public.gmane.org>
2012-03-14 20:15 ` Scott Lovenberg
[not found] ` <4F60FC5C.3050507-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-03-14 20:47 ` Sachin Prabhu
2012-03-14 21:08 ` Steve French
2012-03-15 11:06 ` Jeff Layton
2012-03-14 20:30 ` Sachin Prabhu
2012-03-15 11:44 ` Jeff Layton
2012-03-21 17:38 ` Jeff Layton [this message]
[not found] ` <20120321133855.52901c60-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-03-21 18:33 ` Sachin Prabhu
2012-03-21 18:36 ` Scott Lovenberg
[not found] ` <4F6A1F9F.6070101-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-03-21 19:09 ` Sachin Prabhu
[not found] ` <CAFB9KM0YywoKwjMxijp+T-SxqZLjuOhiXkMRa5y57eYuTHOc6Q@mail.gmail.com>
[not found] ` <CAFB9KM0YywoKwjMxijp+T-SxqZLjuOhiXkMRa5y57eYuTHOc6Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-03-21 19:16 ` Sachin Prabhu
2012-03-21 20:30 ` Jeff Layton
[not found] ` <20120321163051.0fa2c714-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-03-21 20:33 ` Steve French
[not found] ` <CAH2r5mt6NiZmF1JZPG2sZ7bwNFiWpxxQ9Q6OoJXC_st7+oUoZg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-03-21 20:38 ` Jeff Layton
[not found] ` <20120321163818.0418fd2c-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-03-22 15:26 ` [PATCH v2] " Sachin Prabhu
2012-03-22 15:30 ` Jeff Layton
2012-03-22 15:28 ` [PATCH] " Sachin Prabhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120321133855.52901c60@redhat.com \
--to=jlayton-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=sprabhu-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.