From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Wilson Subject: Re: [PATCH 1 of 3 v2] PV-GRUB: Check for errors when applying patches to GRUB Date: Wed, 21 Mar 2012 09:17:52 -0700 Message-ID: <20120321161751.GC2168@US-SEA-R8XVZTX> References: <8124b28e88a438c4f3bd.1332269267@kaos-source-31002.sea31.amazon.com> <20329.47902.521208.252208@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20329.47902.521208.252208@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: Samuel Thibault , "Keir (Xen.org)" , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On Wed, Mar 21, 2012 at 04:27:26AM -0700, Ian Jackson wrote: > > This looks correct but wouldn't it be better done with a "set -e" at > the top of the shell command ? Sure, that works too. And it's the more common style for other Makefiles. Would you like me to repost with this change? Matt