From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Tony Lindgren <tony@atomide.com>
Cc: "Porter, Matt" <mporter@ti.com>, "Dill, Russ" <russ.dill@ti.com>,
"<linux-omap@vger.kernel.org>" <linux-omap@vger.kernel.org>,
"<robert.marklund@stericsson.com>"
<robert.marklund@stericsson.com>,
"<linus.walleij@linaro.org>" <linus.walleij@linaro.org>
Subject: Re: [PATCH] [RFC] Correct registration of multiple gpmc smsc911x devices.
Date: Wed, 21 Mar 2012 19:00:28 +0000 [thread overview]
Message-ID: <20120321190028.GK3226@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20120321183957.GM9859@atomide.com>
[-- Attachment #1: Type: text/plain, Size: 1480 bytes --]
On Wed, Mar 21, 2012 at 11:39:57AM -0700, Tony Lindgren wrote:
> * Porter, Matt <mporter@ti.com> [120321 11:27]:
> > > Hrm? Adding regulator supply mappings anywhere other than the
> > > initialisation for a specific board would be extremely unusual and
> > > rather suspicious.
> The issue here is that we don't want to copy paste the dummy fixed
> regulator all over the board-*.c files, and we don't know how the
> real regulator is wired up.
Well, I don't think it's too unreasonable especially now we've got
the fixed helper stuff which slims it right down - it makes it clear
there's a missing thing that might need to get filled in and makes it
easier to use the same regulator for other devices.
> > Just to be clear, here is the thread on the board-specific approach:
> > https://lkml.org/lkml/2012/2/8/415
> We should use the real regulator if passed from board file.
> And if no real regulator is passed, just use the dummy fixed regulator
> in gpmc-smsc911x.c.
Yes, it should definitely be conditional.
> This patch I posted should fix the situation and allow adding the
> real regulators to board-*.c files when they become known:
> http://www.spinics.net/lists/linux-omap/msg66714.html
That should be changed to pass in a boolean flag rather than a pointer
to platform device - the board may not have direct access to the
relevant regulator (eg, if it's part of a MFD) or the regulator may be
on another bus like I2C (for simpler regulator only devices).
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-03-21 19:00 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-16 11:32 smsc911x on Gumstix Overo/Tobi doesn't work Thomas Klute
2012-03-16 19:33 ` Tony Lindgren
2012-03-19 16:23 ` Thomas Klute
2012-03-19 22:51 ` Tony Lindgren
2012-03-20 14:27 ` Thomas Klute
2012-03-20 19:47 ` Javier Martinez Canillas
2012-03-21 16:29 ` Thomas Klute
2012-03-30 15:28 ` Thomas Klute
2012-04-01 19:20 ` Javier Martinez Canillas
2012-05-02 11:42 ` Thomas Klute
2012-05-03 11:09 ` Javier Martinez Canillas
2012-05-09 11:47 ` Thomas Klute
2012-03-21 17:55 ` [PATCH] [RFC] Correct registration of multiple gpmc smsc911x devices Russ Dill
2012-03-21 18:13 ` Mark Brown
2012-03-21 18:18 ` Porter, Matt
2012-03-21 18:24 ` Porter, Matt
2012-03-21 18:39 ` Tony Lindgren
2012-03-21 19:00 ` Mark Brown [this message]
2012-03-21 19:30 ` Tony Lindgren
2012-03-21 19:38 ` Mark Brown
2012-03-21 19:41 ` Tony Lindgren
2012-03-21 20:45 ` Russ Dill
2012-03-22 5:19 ` [PATCH 00/13] Fixup gmpc smsc911x regulator handling Russ Dill
2012-03-22 5:19 ` [PATCH 01/13] Remove odd gpmc_cfg/board_data redirection Russ Dill
2012-03-22 5:19 ` [PATCH 02/13] Fix possible stale smsc911x flags Russ Dill
2012-03-22 5:19 ` [PATCH 03/13] Remove unused rate calculation Russ Dill
2012-03-22 5:19 ` [PATCH 04/13] Remove non-existent parameter from fixed-helper.c kernel doc Russ Dill
2012-03-22 11:36 ` Mark Brown
2012-03-22 18:30 ` Russ Dill
2012-03-22 5:19 ` [PATCH 05/13] Remove regulator support from gmpc-smsc911x Russ Dill
2012-03-22 5:19 ` [PATCH 06/13] Add dummy smsc911x regulators to cm-t35 Russ Dill
2012-03-22 5:19 ` [PATCH 07/13] Add dummy smsc911x regulators to igep0020 Russ Dill
2012-03-22 5:19 ` [PATCH 08/13] Add dummy smsc911x regulators to ldp Russ Dill
2012-03-22 7:06 ` Koen Kooi
2012-03-22 5:19 ` [PATCH 09/13] Add dummy smsc911x regulators to omap3evm Russ Dill
2012-03-22 7:07 ` Koen Kooi
2012-03-22 7:16 ` Russ Dill
2012-03-22 5:19 ` [PATCH 10/13] Add dummy smsc911x regulators to omap3logic Russ Dill
2012-03-22 5:19 ` [PATCH 11/13] Add dummy smsc911x regulators to omap3stalker Russ Dill
2012-03-22 5:19 ` [PATCH 12/13] Add dummy smsc911x regulators to overo Russ Dill
2012-03-22 5:19 ` [PATCH 13/13] Add dummy smsc911x regulators to zoom-debugboard Russ Dill
2012-03-22 11:37 ` Mark Brown
2012-03-22 18:29 ` Russ Dill
2012-03-23 8:49 ` Igor Grinberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120321190028.GK3226@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linus.walleij@linaro.org \
--cc=linux-omap@vger.kernel.org \
--cc=mporter@ti.com \
--cc=robert.marklund@stericsson.com \
--cc=russ.dill@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.