From: Tony Lindgren <tony@atomide.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: "Porter, Matt" <mporter@ti.com>, "Dill, Russ" <russ.dill@ti.com>,
"<linux-omap@vger.kernel.org>" <linux-omap@vger.kernel.org>,
"<robert.marklund@stericsson.com>"
<robert.marklund@stericsson.com>,
"<linus.walleij@linaro.org>" <linus.walleij@linaro.org>
Subject: Re: [PATCH] [RFC] Correct registration of multiple gpmc smsc911x devices.
Date: Wed, 21 Mar 2012 12:41:33 -0700 [thread overview]
Message-ID: <20120321194133.GP9859@atomide.com> (raw)
In-Reply-To: <20120321193839.GM3226@opensource.wolfsonmicro.com>
* Mark Brown <broonie@opensource.wolfsonmicro.com> [120321 12:41]:
> On Wed, Mar 21, 2012 at 12:30:47PM -0700, Tony Lindgren wrote:
> > * Mark Brown <broonie@opensource.wolfsonmicro.com> [120321 12:03]:
>
> > > That should be changed to pass in a boolean flag rather than a pointer
> > > to platform device - the board may not have direct access to the
> > > relevant regulator (eg, if it's part of a MFD) or the regulator may be
> > > on another bus like I2C (for simpler regulator only devices).
>
> > Hmm I see. This means that we need to patch some board files anyways
> > for the boolean flag to use the fixed regulator. This is because for
> > some cases vddvario and vdd33a regulators can come from the mfd/tps/twl
> > chip and it's unsafe to assume that gpmc-smsc911x.c can set up these
> > regulators automatically. Passing a boolean flag to not set up the
> > default regulator would work too, but we'd rather eventually see
> > the real board specific regulators being patched in.
>
> Yes, ideally the boards would do everything and gpmc-smsc911x.c should
> be able to completely ignore regulators.
OK, great, let's do that then.
> > So if that's the case, we might as well patch the board files
> > to add the fixed regulators for each one and drop all the regulator
> > code from gpmc-smsc911x.c.
>
> That's my preferred option, hopefully with the helpers we have for
> regulator registration we shouldn't need to add device specific helpers.
Russ, care to update your patch accordingly? Those helpers are queued
in linux-next.
Regards,
Tony
next prev parent reply other threads:[~2012-03-21 19:41 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-16 11:32 smsc911x on Gumstix Overo/Tobi doesn't work Thomas Klute
2012-03-16 19:33 ` Tony Lindgren
2012-03-19 16:23 ` Thomas Klute
2012-03-19 22:51 ` Tony Lindgren
2012-03-20 14:27 ` Thomas Klute
2012-03-20 19:47 ` Javier Martinez Canillas
2012-03-21 16:29 ` Thomas Klute
2012-03-30 15:28 ` Thomas Klute
2012-04-01 19:20 ` Javier Martinez Canillas
2012-05-02 11:42 ` Thomas Klute
2012-05-03 11:09 ` Javier Martinez Canillas
2012-05-09 11:47 ` Thomas Klute
2012-03-21 17:55 ` [PATCH] [RFC] Correct registration of multiple gpmc smsc911x devices Russ Dill
2012-03-21 18:13 ` Mark Brown
2012-03-21 18:18 ` Porter, Matt
2012-03-21 18:24 ` Porter, Matt
2012-03-21 18:39 ` Tony Lindgren
2012-03-21 19:00 ` Mark Brown
2012-03-21 19:30 ` Tony Lindgren
2012-03-21 19:38 ` Mark Brown
2012-03-21 19:41 ` Tony Lindgren [this message]
2012-03-21 20:45 ` Russ Dill
2012-03-22 5:19 ` [PATCH 00/13] Fixup gmpc smsc911x regulator handling Russ Dill
2012-03-22 5:19 ` [PATCH 01/13] Remove odd gpmc_cfg/board_data redirection Russ Dill
2012-03-22 5:19 ` [PATCH 02/13] Fix possible stale smsc911x flags Russ Dill
2012-03-22 5:19 ` [PATCH 03/13] Remove unused rate calculation Russ Dill
2012-03-22 5:19 ` [PATCH 04/13] Remove non-existent parameter from fixed-helper.c kernel doc Russ Dill
2012-03-22 11:36 ` Mark Brown
2012-03-22 18:30 ` Russ Dill
2012-03-22 5:19 ` [PATCH 05/13] Remove regulator support from gmpc-smsc911x Russ Dill
2012-03-22 5:19 ` [PATCH 06/13] Add dummy smsc911x regulators to cm-t35 Russ Dill
2012-03-22 5:19 ` [PATCH 07/13] Add dummy smsc911x regulators to igep0020 Russ Dill
2012-03-22 5:19 ` [PATCH 08/13] Add dummy smsc911x regulators to ldp Russ Dill
2012-03-22 7:06 ` Koen Kooi
2012-03-22 5:19 ` [PATCH 09/13] Add dummy smsc911x regulators to omap3evm Russ Dill
2012-03-22 7:07 ` Koen Kooi
2012-03-22 7:16 ` Russ Dill
2012-03-22 5:19 ` [PATCH 10/13] Add dummy smsc911x regulators to omap3logic Russ Dill
2012-03-22 5:19 ` [PATCH 11/13] Add dummy smsc911x regulators to omap3stalker Russ Dill
2012-03-22 5:19 ` [PATCH 12/13] Add dummy smsc911x regulators to overo Russ Dill
2012-03-22 5:19 ` [PATCH 13/13] Add dummy smsc911x regulators to zoom-debugboard Russ Dill
2012-03-22 11:37 ` Mark Brown
2012-03-22 18:29 ` Russ Dill
2012-03-23 8:49 ` Igor Grinberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120321194133.GP9859@atomide.com \
--to=tony@atomide.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linus.walleij@linaro.org \
--cc=linux-omap@vger.kernel.org \
--cc=mporter@ti.com \
--cc=robert.marklund@stericsson.com \
--cc=russ.dill@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.