Re: [RFC] [PATCH] NFC: The core part should generate the target index

[Samuel Ortiz <sameo@linux.intel.com>]

Hi Ilan,

On Thu, Mar 22, 2012 at 07:56:27AM +0000, Elias, Ilan wrote:
> Hi Samuel,
>  
> > Ilan, could you please comment on this patch and also make 
> > sure that it
> > doesn't break multiple targets support for NCI ?
> It seems to me that this patch doesn't break multiple targets support for NCI.
Thanks for checking.


> > diff --git a/net/nfc/rawsock.c b/net/nfc/rawsock.c
> > index 5a839ce..47fcf0d 100644
> > --- a/net/nfc/rawsock.c
> > +++ b/net/nfc/rawsock.c
> > @@ -92,6 +92,18 @@ static int rawsock_connect(struct socket 
> > *sock, struct sockaddr *_addr,
> >  		goto error;
> >  	}
> >  
> > +	if (addr->target_idx > dev->target_idx - 1 ||
> > +	    addr->target_idx < dev->target_idx - dev->n_targets) {
> > +		rc = -EINVAL;
> > +		goto error;
> > +	}
> > +
> > +	if (addr->target_idx > dev->target_idx - 1 ||
> > +	    addr->target_idx < dev->target_idx - dev->n_targets) {
> > +		rc = -EINVAL;
> > +		goto error;
> > +	}
> > +
> It looks like the 'if' statement you added appears twice.
Oops, thanks for that one too.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/