From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH 2/2] drm/i915: use semaphores for the
 display plane
Date: Thu, 22 Mar 2012 09:48:47 -0700
Message-ID: <20120322094847.26623532@bwidawsk.net>
References: <1332375553-7174-1-git-send-email-ben@bwidawsk.net>
	<1332375553-7174-3-git-send-email-ben@bwidawsk.net>
	<aefc95$3ipt0g@orsmga001.jf.intel.com>
	<20120322090709.59f3f5f2@bwidawsk.net>
	<c55c5d$2cnmfu@AZSMGA002.ch.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from cloud01.chad-versace.us (184-106-247-128.static.cloud-ips.com
	[184.106.247.128])
	by gabe.freedesktop.org (Postfix) with ESMTP id CEB68A0EEE
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 22 Mar 2012 09:48:55 -0700 (PDT)
In-Reply-To: <c55c5d$2cnmfu@AZSMGA002.ch.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Thu, 22 Mar 2012 16:18:54 +0000
Chris Wilson <chris@chris-wilson.co.uk> wrote:

> On Thu, 22 Mar 2012 09:07:09 -0700, Ben Widawsky <ben@bwidawsk.net> wrote:
> > On Thu, 22 Mar 2012 09:56:07 +0000
> > Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > 
> > > On Wed, 21 Mar 2012 17:19:13 -0700, Ben Widawsky <ben@bwidawsk.net>
> > > wrote:
> > > >   * For the display plane, we want to be in the GTT but out of any
> > > > write
> > > > - * domains. So in many ways this looks like set_to_gtt_domain()
> > > > apart from the
> > > > - * ability to pipeline the waits, pinning and any additional
> > > > subtleties
> > > > - * that may differentiate the display plane from ordinary buffers.
> > > > + * domains. So in many ways this looks like set_to_gtt_domain().
> > > ...apart from the whole pinning and pipelining. It looks less like
> > > set-to-gtt-domain over time.
> > > 
> > > Not an improvement. I'll be the first to admit that it is not a great
> > > comment, but at least it does try to capture why we don't just treat
> > > the display plane as GTT. A better comment would explain our concept
> > > of display plane and pipelining.
> > 
> > Separate patch though, don't you think? And it is now pipe-lining the
> > waits, so I'm confused why you don't think it's an improvement.
> 
> Right. So how does removing the hint of why pin-to-display is different
> from set-to-gtt when it now performs said function help improve the
> comment? I completely agree that changing that comment is outside of the
> scope of this patch.
> -Chris
> 

Can you volunteer a better description? I'll undo the comment change in
my patch #2 and use whatever you come up with. If not, I'll get to this
when I get to it.