From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Venu Byravarasu <vbyravarasu@nvidia.com>
Cc: lrg@ti.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] regulator: Add TPS65090 regulator driver
Date: Thu, 22 Mar 2012 16:02:56 +0000 [thread overview]
Message-ID: <20120322160256.GK3091@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1332421449-15656-1-git-send-email-vbyravarasu@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 665 bytes --]
On Thu, Mar 22, 2012 at 06:34:09PM +0530, Venu Byravarasu wrote:
> Add TPS65090 regulator driver
>
> TPS65090 PMIC from TI consists of 3 step down converters,
> 2 always on LDOs and 7 current limited load switches. The
> output voltages are ON/OFF controllable and are meant to
> supply power to the components on target board.
Applied, but...
> + rdev = regulator_register(&ri->desc, &pdev->dev,
> + &tps_pdata->regulator, ri, NULL);
> + if (IS_ERR_OR_NULL(rdev)) {
...please submit an incremental patch changing this to plain IS_ERR(),
regulator_register() only returns error pointers. Note that no other
regulator drivers do this check.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-03-22 16:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-22 13:04 [PATCH v3] regulator: Add TPS65090 regulator driver Venu Byravarasu
2012-03-22 16:02 ` Mark Brown [this message]
2012-03-26 3:53 ` Venu Byravarasu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120322160256.GK3091@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=vbyravarasu@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.