From: Thierry Reding <thierry.reding@avionic-design.de>
To: Ted Ts'o <tytso@mit.edu>, Artem Bityutskiy <dedekind1@gmail.com>,
Jan Kara <jack@suse.cz>,
linux-kernel@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>,
linux-ext4@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] ext2: Don't export ext2_mask_flags() to user space
Date: Thu, 22 Mar 2012 17:47:51 +0100 [thread overview]
Message-ID: <20120322164751.GA17885@avionic-0098.adnet.avionic-design.de> (raw)
In-Reply-To: <20120322162825.GA4028@thunk.org>
[-- Attachment #1: Type: text/plain, Size: 1410 bytes --]
* Ted Ts'o wrote:
> On Thu, Mar 22, 2012 at 08:00:41AM +0200, Artem Bityutskiy wrote:
> > On Thu, 2012-03-22 at 06:53 +0100, Thierry Reding wrote:
> > > What's the recommended fix for packages that cannot or will not use
> > > libext2fs, like busybox? Copy the required parts into a private header
> > > and use that instead?
> >
> > The normal way is to just keep a private copy of the whole header file.
> > Because the on-disk format stays compatible, those programs do not have
> > to update the header very often - only rarely if they want to support
> > some new feature.
>
> Even if they're not iwlling to use libext2fs (for space reasons, I
> would assume? It can't be because of license compatibility issues
> since they are both GPLv2), they could just simply grab the ext2_fs.h
> from e2fsprogs. That has all of the file system definitions for ext2,
> ext3, and ext4.
In fact there is already a file, e2fs_defs.h, that seems to be based on the
contents of the ext2_fs.h from the kernel. I've posted two patches to the
busybox mailing list that fix the build without using linux/ext2_fs.h. For
reference, they can be found here:
http://lists.busybox.net/pipermail/busybox/2012-March/077563.html
http://lists.busybox.net/pipermail/busybox/2012-March/077562.html
Do you still want me to prepare a patch to unexport ext2_fs.h or will you
take care of it?
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2012-03-22 16:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-21 21:50 [PATCH] ext2: Don't export ext2_mask_flags() to user space Thierry Reding
2012-03-21 22:23 ` Jan Kara
2012-03-21 23:16 ` Ted Ts'o
2012-03-22 5:53 ` Thierry Reding
2012-03-22 6:00 ` Artem Bityutskiy
2012-03-22 16:28 ` Ted Ts'o
2012-03-22 16:47 ` Thierry Reding [this message]
2012-03-22 18:31 ` Ted Ts'o
2012-03-23 9:27 ` [PATCH] ext2: No longer export ext2_fs.h " Thierry Reding
2012-03-23 9:27 ` Thierry Reding
2012-03-23 13:13 ` Ted Ts'o
2012-03-23 17:55 ` Al Viro
2012-03-24 21:51 ` Ted Ts'o
2012-03-24 22:16 ` H. Peter Anvin
2012-03-25 1:16 ` Ted Ts'o
2012-03-22 17:31 ` [PATCH] ext2: Don't export ext2_mask_flags() " Al Viro
2012-03-23 0:25 ` Andreas Dilger
2012-03-24 6:51 ` Mike Frysinger
2012-03-24 6:50 ` Mike Frysinger
2012-03-24 6:50 ` Mike Frysinger
2012-03-24 8:37 ` Al Viro
2012-03-24 17:59 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120322164751.GA17885@avionic-0098.adnet.avionic-design.de \
--to=thierry.reding@avionic-design.de \
--cc=dedekind1@gmail.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.